From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: marcht@proton.me, Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: qcom: audioreach: only disconnect the route a mixer control owns
Date: Sun, 15 Nov 2026 10:50:38 +0000 [thread overview]
Message-ID: <f8d9be2d-b8a3-4f54-803f-dd9c974280f7@oss.qualcomm.com> (raw)
In-Reply-To: <20261111-q6apm-fixes-v1-2-1beb5702b372@proton.me>
On 11/11/26 10:54 AM, Marc Herrero via B4 Relay wrote:
> if (ucontrol->value.integer.value[0]) {
> audioreach_connect_sub_graphs(data, scontrol, dapm_scontrol, true);
> snd_soc_dapm_mixer_update_power(dapm, kcontrol, 1, NULL);
> - } else {
> + } else if (audioreach_is_vmixer_connected(data, scontrol,
> dapm_scontrol)) {
> audioreach_connect_sub_graphs(data, scontrol, dapm_scontrol, false);
move this type of check inside the audioreach_connect_sub_graphs itself.
--srini
> snd_soc_dapm_mixer_update_power(dapm, kcontrol, 0, NULL);
> }
prev parent reply other threads:[~2026-11-15 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 10:54 [PATCH 0/2] ASoC: qcom: audioreach: fix S24_LE playback and route mixer disconnects Marc Herrero via B4 Relay
2026-11-11 10:54 ` [PATCH 1/2] ASoC: qcom: audioreach: use a 32-bit container for S24_LE PCM Marc Herrero via B4 Relay
2026-11-15 11:52 ` Srinivas Kandagatla
2026-11-11 10:54 ` [PATCH 2/2] ASoC: qcom: audioreach: only disconnect the route a mixer control owns Marc Herrero via B4 Relay
2026-11-12 19:01 ` Mark Brown
2026-11-15 10:50 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8d9be2d-b8a3-4f54-803f-dd9c974280f7@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=marcht@proton.me \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.dev \
--cc=srini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®