From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f228.google.com (mail-dy1-f228.google.com [74.125.82.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD1A53822AB for ; Mon, 13 Apr 2026 17:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776102682; cv=none; b=g4+JGTUMN89cvCrg5A2TeiKE1h2+NhdtZmzw5YTxfijc3+iuVRObNgKQiyDUOZP40Erp3FipTdMR2Ndfi+IKUUy4j0UvI7NmewRT8/hJrHagJhOgMqZ4h0i08ggE8btKOw42N5e/BHZkMg31nMLkGSmJhLdFTMyN0srp1sRXkxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776102682; c=relaxed/simple; bh=93I+Xu+Ho0+KJ1Wx9pdA3mEt2KEaHAtZqLLThZJyPGA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dMX67WXfUZlhL2Kn/f7AnM9j8sRMs4XLu2ECSXP8m+WSFjFqMHlup+Ybnn1go9Ckr8qKkc8ONnOqcTPss5xVmScJhWsgdD56PZT5E9prw3O9WHSE3iFiKT5RW9cmCA33wCoszwp0/0fm4kiIfw7UBu8N/JjeZL2J8dqqG9LSq8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=XlRkKdQ9; arc=none smtp.client-ip=74.125.82.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XlRkKdQ9" Received: by mail-dy1-f228.google.com with SMTP id 5a478bee46e88-2bd9a485bd6so9853302eec.1 for ; Mon, 13 Apr 2026 10:51:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776102679; x=1776707479; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RWKO9vDsSjUTJZzAKzLLCDdYMLbrt3D+hRWkiFgwafM=; b=BbScsxktp1+b8wi0btRHZM0pfItVocDxlFnwL+TD1HvLozYKzFGJ9kbddS1TwCfk9v vNbk41OSDplNRyh+EV/dbtK2CkQycd7PxJ889aPkQ+STFKPjM/99Z7ujvbAAZf+kzyxo kYJFks2iD2gDC0daV7zQkGInctTMariVAE/sa+MLgCU6eqU6d2ZuPcpEt6jZQfaU8jev kYAQJp0pUhRdFvOdEnxsdNol8owXcav/ybqtn+R9X/tL2c2unWvT92c6QG8NUQ+IUUVB Egrh3QpAqW9ZbQYrDSpUNbe1M6ZINFcvhRtqI3gcCNLy1VQnk12WOawqTf/IxrrHUs9N i4EA== X-Forwarded-Encrypted: i=1; AFNElJ9kMUTvUIphjSOGTBapoA/A0+9QWvLXgtF+IK1AHAevwI1t52tWAw5f8qcNOlQb41WcUWaKLeDUP9TD2tA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+jFeEEkopEFFdxyOenIvPXpRNx1CKZPGQyHbUZc6f/4by9xTz 9tq8YDl3UPCZ1sctms/amS3ap5YjlpfE60ubFW7mZUWpBJUR/FxbbfGspgX9cZIxO3KsvnGtDZd hVaUnT/UY6CrQEFcSp3Pl+UMCIeh2xy6CCdbPEV7Glb0Vg3MpG6on1y4k+kYq+CxyBDKI/aDMt+ HBI1grJOB11tW19XAeZWHw9hlD8i3DXQvnOyZcyJyGBWkEz9Aj8C6T9Gac86g4K6m0iXYfJGaWN zKGzfA3/yC7HqfobA== X-Gm-Gg: AeBDiev38jl888hpYmpRXtpFDtBJs7x7iwzd+XExLAoVuiuhCm0kpDprjqJAfpJDt/g x9++vAtEqa/b8EW7g2TG8c6h+LRaLGaeidqNEGxgNV/hXZdVH/rgxvH+n/NrmcgVBp6/cxTET8P qImxLc5iv1LGVX7uAbwiHR+TR6jGzG1ccT8ldOQpeJeNIi9KB6Yz76F8mRuM56mQcDAmLziDj67 D8+7DkiJ1/Vb9ZbQf1fsKR6z+N8pu6RubyiCmMh2nrQdM6hid5MBp7I4iude1gQ4fhN4ZEu9eA2 +uJgGYhFZY419ldUJS/H8EVgFepekxKQETs85Li1TRWqhppVe3XHFla9cqH/ZAlCMu5xn/IDffU xGffziQ8NsBk98s2ap2dVnHBW3H5e9RPIl3/BXaDLlowR0D+F4u8qQdXxi6B/dK5pHpE+6XjbZF CKUkBaI/gAumk9cjAKDuw3ENPSIwwQ4/uTweUbtQutNUMo2vTY/4BUFd8= X-Received: by 2002:a05:7300:a90c:b0:2d9:dc9c:1613 with SMTP id 5a478bee46e88-2d9dc9c1d6emr2211917eec.21.1776102678516; Mon, 13 Apr 2026 10:51:18 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-2d56150a707sm874248eec.21.2026.04.13.10.51.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2026 10:51:18 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2cc75e79b97so17010461eec.1 for ; Mon, 13 Apr 2026 10:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1776102677; x=1776707477; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RWKO9vDsSjUTJZzAKzLLCDdYMLbrt3D+hRWkiFgwafM=; b=XlRkKdQ9iB92WbrwWAW2P9tluHDOzsvsOlnCqWriOUx1IiGBJodpFCmwVx97vQa2ii FyRqdoKDjnWufsiz6UXrhiVwxgJ/q1DzdYmuZCJReeMAXsTfdUmD+vFERZiLYY8JJI1C LLwBPcEFeTRiQP5hzF0vxoPp+pohSPWpl8YgU= X-Forwarded-Encrypted: i=1; AFNElJ+q+Eq51PRBJt9+MimaeMbDCNxn36DGOoIFcFJqrNherQT3qCNDm8LSRt5vbXG+iMIRs6HejUMEMXgxRs8=@vger.kernel.org X-Received: by 2002:a05:7300:cb0e:b0:2ce:f3d7:221 with SMTP id 5a478bee46e88-2d589463e5cmr8023451eec.17.1776102676779; Mon, 13 Apr 2026 10:51:16 -0700 (PDT) X-Received: by 2002:a05:7300:cb0e:b0:2ce:f3d7:221 with SMTP id 5a478bee46e88-2d589463e5cmr8023420eec.17.1776102676145; Mon, 13 Apr 2026 10:51:16 -0700 (PDT) Received: from [10.14.4.141] ([192.19.161.248]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d562db64c4sm17140089eec.27.2026.04.13.10.51.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 10:51:15 -0700 (PDT) Message-ID: Date: Mon, 13 Apr 2026 10:51:14 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: bdc: allocate phys with main struct To: Rosen Penev , linux-usb@vger.kernel.org Cc: Al Cooper , Broadcom internal kernel review list , Greg Kroah-Hartman , Kees Cook , "Gustavo A. R. Silva" , open list , open "list:KERNEL" HARDENING "(not" covered by other "areas):Keyword:b__counted_by(_le|_be)?b" References: <20260411041252.166816-1-rosenp@gmail.com> Content-Language: en-US From: Justin Chen In-Reply-To: <20260411041252.166816-1-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 4/10/26 9:12 PM, Rosen Penev wrote: > Use a flexible array member to combine allocations and simplify code > slightly. No need for a branch deciding whether to allocate or not. > > Add __counted_by for extra runtime analysis. > > Signed-off-by: Rosen Penev > --- > drivers/usb/gadget/udc/bdc/bdc.h | 2 +- > drivers/usb/gadget/udc/bdc/bdc_core.c | 20 +++++++------------- > 2 files changed, 8 insertions(+), 14 deletions(-) > > diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h > index 2f4abf6f8f77..cc961161eb46 100644 > --- a/drivers/usb/gadget/udc/bdc/bdc.h > +++ b/drivers/usb/gadget/udc/bdc/bdc.h > @@ -409,7 +409,6 @@ struct bdc { > spinlock_t lock; > > /* generic phy */ > - struct phy **phys; > int num_phys; > /* num of endpoints for a particular instantiation of IP */ > unsigned int num_eps; > @@ -453,6 +452,7 @@ struct bdc { > */ > struct delayed_work func_wake_notify; > struct clk *clk; > + struct phy *phys[] __counted_by(num_phys); > }; > > static inline u32 bdc_readl(void __iomem *base, u32 offset) > diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c > index 438201dc96ca..4b16b85da450 100644 > --- a/drivers/usb/gadget/udc/bdc/bdc_core.c > +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c > @@ -487,14 +487,20 @@ static int bdc_probe(struct platform_device *pdev) > int irq; > u32 temp; > struct device *dev = &pdev->dev; > + int num_phys; > int phy_num; > > dev_dbg(dev, "%s()\n", __func__); > > - bdc = devm_kzalloc(dev, sizeof(*bdc), GFP_KERNEL); > + num_phys = of_count_phandle_with_args(dev->of_node, > + "phys", "#phy-cells"); > + bdc = devm_kzalloc(dev, struct_size(bdc, phys, num_phys), GFP_KERNEL); > if (!bdc) > return -ENOMEM; > > + bdc->num_phys = num_phys; > + dev_info(dev, "Using %d phy(s)\n", bdc->num_phys); > + This feels like a step sideways instead of an improvement IMHO. And we are also moving the allocation and dev_info() print. Is there a reason to change the ordering? Justin > bdc->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(bdc->regs)) > return PTR_ERR(bdc->regs); > @@ -508,18 +514,6 @@ static int bdc_probe(struct platform_device *pdev) > bdc->dev = dev; > dev_dbg(dev, "bdc->regs: %p irq=%d\n", bdc->regs, bdc->irq); > > - bdc->num_phys = of_count_phandle_with_args(dev->of_node, > - "phys", "#phy-cells"); > - if (bdc->num_phys > 0) { > - bdc->phys = devm_kcalloc(dev, bdc->num_phys, > - sizeof(struct phy *), GFP_KERNEL); > - if (!bdc->phys) > - return -ENOMEM; > - } else { > - bdc->num_phys = 0; > - } > - dev_info(dev, "Using %d phy(s)\n", bdc->num_phys); > - > for (phy_num = 0; phy_num < bdc->num_phys; phy_num++) { > bdc->phys[phy_num] = devm_of_phy_get_by_index( > dev, dev->of_node, phy_num);