From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B5AC41513 for ; Thu, 17 Aug 2023 10:17:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349996AbjHQKQi (ORCPT ); Thu, 17 Aug 2023 06:16:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350091AbjHQKQd (ORCPT ); Thu, 17 Aug 2023 06:16:33 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 09E5030FF for ; Thu, 17 Aug 2023 03:16:11 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8DFD6D75; Thu, 17 Aug 2023 03:16:51 -0700 (PDT) Received: from [10.163.56.152] (unknown [10.163.56.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03A4D3F64C; Thu, 17 Aug 2023 03:16:05 -0700 (PDT) Message-ID: Date: Thu, 17 Aug 2023 15:46:03 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] coresight: trbe: Allocate platform data per device Content-Language: en-US To: Suzuki K Poulose , James Clark , hejunhao3@huawei.com Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathan.cameron@huawei.com, leo.yan@linaro.org, mike.leach@linaro.org, linuxarm@huawei.com, yangyicong@huawei.com, prime.zeng@hisilicon.com References: <20230814093813.19152-1-hejunhao3@huawei.com> <20230816141008.535450-1-suzuki.poulose@arm.com> <20230816141008.535450-2-suzuki.poulose@arm.com> <9cd9f83c-7778-2d87-a175-a4cb7ceb8723@arm.com> <3f681660-a0f0-20cb-b79b-7b2e2f6a1b5c@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/17/23 15:31, Suzuki K Poulose wrote: > On 17/08/2023 10:24, James Clark wrote: >> >> >> On 17/08/2023 07:37, Anshuman Khandual wrote: >>> Hi Suzuki, >>> >>> Seems like this patch is going to conflict with the below proposed change >>> >>> https://lore.kernel.org/all/20230817055405.249630-4-anshuman.khandual@arm.com/ >>> >>> Please let me know how should we resolve this conflict. >> >> We could merge them both, with the fixes: one first, just to acknowledge >> that there was a problem. But I suppose your one will have to be rebased >> on top. >> >>> >>> On 8/16/23 19:40, Suzuki K Poulose wrote: >>>> Coresight TRBE driver shares a single platform data (which is empty btw). >>>> However, with the commit 4e8fe7e5c3a5 >>>> ("coresight: Store pointers to connections rather than an array of them") >>>> the coresight core would free up the pdata, resulting in multiple attempts >>>> to free the same pdata for TRBE instances. Fix this by allocating a pdata per >>>> coresight_device. >>>> >>>> Fixes: 3fbf7f011f24 ("coresight: sink: Add TRBE driver") >>> >>> The above mentioned commit i.e 4e8fe7e5c3a5 seems to be a more recent one which >>> has triggered this problem. But would the problem be still there without that ? >>> Else 'Fixes:' tag would need changing. >>> >> >> Yes I think the fixes tag should point to 4e8fe7e5c3a5. > > Agreed, I will change the fixes tag and push this. In the first patch, the last hunk might not be required to fix the IPI problem and in fact might be bit problematic as well. Besides, could you please hold off pushing this change into coresight tree for some time ?