From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18ED42594A1; Thu, 12 Dec 2024 03:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733973145; cv=none; b=sdaV+Jk8uIRIx/N1weUtIDPAxqRoVvHXF2z+naP7mPzGpLxLxGkImEU8SJ0+Q+rpVvbgXoJS2DKV1VHrRok4IMYz7tfkMMa57HoHtnO9f9jkQ1+bDS/sCTHzW0AEHMjtzWrbRCJigwRJGVn3hmqTp8d25SXJRM9s5lB1J7d94Dc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733973145; c=relaxed/simple; bh=7CMznybx7WCztwUNGY3f/zak8NAtURLicRpCcXUXEEo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=DBswwSsvpNoq+XqJUTK+nXo+gDMwgBdltnzDzRVCAoLVZOJ2HaJYAdEZC83agjfNLUNnIa+ePTmL6/TiUpYGX1lVJ9Ex1u7u3FQk0XexrG4fFxF7PJhyzgTfJ9iVcYcgH29BtAEyIDmbnjTf2aHaNO81GmptWNlOpH7VhnhefDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=mLkiEJu9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="mLkiEJu9" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BBHD9ZN003468; Thu, 12 Dec 2024 03:12:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aRzH7/n8H0qoiHoXdTaaw8Za2IcDg8YDM+3wHjukb2I=; b=mLkiEJu95mn2A1e4 UKRQWPAm75p33tFu8nYpzg8tPEgcW+D44mEAtFaTnZDpMUNpkVH5JRZHvLLk/0fY UNydlRr+SlqbtNQSa7MeHNaFKPj/BVLLEgPd/NU/CLuiLaIE1J9KdZPtavnPhywN vS9DRClUYRbJxLDASe6QnqFaZqSeVBQvwLzE4oVtJ+oF0M+vJ5b7cnjOcmuguQ2z bdLfOFkRazsANdTXdis1/aj1EdTQVGErvl2nt5UrtZQnSrWevg9/scDYeSFG2MMK pCsRmW1TqG/+C9D1UdUOoMz8ZNduBNNG/bIM2iZAmXLV0r36cnAY97CQw58KrH0Q 1r8Tyw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43ee3nf38t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Dec 2024 03:12:15 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BC3CEeH004728 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Dec 2024 03:12:14 GMT Received: from [10.110.5.240] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 11 Dec 2024 19:12:10 -0800 Message-ID: Date: Wed, 11 Dec 2024 19:12:09 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets To: Dmitry Baryshkov , Rob Clark , Sean Paul , Marijn Suijten , David Airlie , "Simona Vetter" , Paloma Arellano CC: Douglas Anderson , Stephen Boyd , , , , References: <20241212-fd-dp-audio-fixup-v3-0-0b1c65e7dba3@linaro.org> <20241212-fd-dp-audio-fixup-v3-9-0b1c65e7dba3@linaro.org> Content-Language: en-US From: Abhinav Kumar In-Reply-To: <20241212-fd-dp-audio-fixup-v3-9-0b1c65e7dba3@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: us07FsJp4xEXrCICbIlvwTSaLMssqDlL X-Proofpoint-ORIG-GUID: us07FsJp4xEXrCICbIlvwTSaLMssqDlL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 mlxlogscore=778 lowpriorityscore=0 adultscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412120021 On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly > to program audio packet data. Use 0 as Packet ID, as it was not > programmed earlier. > > Reviewed-by: Stephen Boyd > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_audio.c | 288 +++++++++----------------------------- > 1 file changed, 66 insertions(+), 222 deletions(-) > Please confirm if dp audio was re-tested after this change. I would prefer its retested.