Re: [PATCH v2] dt-bindings: display: panel: mipi-dbi-spi: add sitronix,st7789v-tft28

[Frese <freseenzo@gmail.com>]

Hi Krzysztof,

Thanks for the review, this is one of my first kernel contributions,
so please bear with me.

This panel is a generic hobbyist module, wired via jumpers to a stock
Raspberry Pi 4B, not soldered onto any fixed product like
saef,sftc154b (Anbernic RG-Nano) or shineworld,lh133k (LXA boards).
Mainline has no Raspberry Pi overlay tree, so there's no in-tree
consumer to add. I noticed sainsmart18 currently has no in-tree
consumer either, though it was added as part of the original binding's
example, so I'm not sure that's a strong precedent. Would a
documentation example, or an out-of-tree overlay demonstrating the
tested wiring, be an acceptable alternative here?

Vendor prefix was already fixed in v2 (sitronix,st7789v-tft28) —
sorry the subject change broke Patchwork's series detection.

Thanks,
Enzo

On Sun, 2026-09-13 at 11:34 +0200, Krzysztof Kozlowski wrote:
> On Fri, Sep 11, 2026 at 05:33:42PM -0300, Enzo Frese wrote:
> > This is a generic 2.8" 240x320 RGB LCD panel with a MIPI DBI
> > compatible
> > SPI interface, based on the Sitronix ST7789V controller. It is
> > commonly
> > sold by various resellers without an identifiable original
> > manufacturer
> > name printed on the PCB.
> > 
> > A basic mipi-dbi-cmd[1] script to get the display running looks
> > like
> > this:
> > 
> > $ cat sitronix,st7789v-tft28.txt
> > command 0x11
> > delay 120
> > command 0x3a 0x55
> > command 0xb2 0x05 0x05 0x00 0x33 0x33
> > command 0xb7 0x75
> > command 0xc2 0x01 0xff
> > command 0xc3 0x13
> > command 0xc4 0x20
> > command 0xbb 0x22
> > command 0xc5 0x20
> > command 0xd0 0xa4 0xa1
> > command 0xe0 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x44 0x45 0x0f 0x17
> > 0x16 0x2b 0x33
> > command 0xe1 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x43 0x45 0x0f 0x16
> > 0x16 0x2b 0x33
> > command 0x36 0x00
> > command 0x29
> > command 0x21
> > 
> > $ mipi-dbi-cmd sitronix,st7789v-tft28.bin sitronix,st7789v-
> > tft28.txt
> > 
> > Tested on a Raspberry Pi 4B using the panel-mipi-dbi driver.
> > 
> > [1]: https://github.com/notro/panel-mipi-dbi
> > 
> > Signed-off-by: Enzo Frese <freseenzo@gmail.com>
> > ---
> >  .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml    |
> > 1 +
> >  1 file changed, 1 insertion(+)
> > 
> 
> So v2 send in a few minutes, with different subject so Patchwork
> could
> not detect that it is v2, thus I spent time there.
> 
> Same comments.
> 
> Best regards,
> Krzysztof