From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01518C64E7C for ; Mon, 30 Nov 2020 03:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA29A20757 for ; Mon, 30 Nov 2020 03:06:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N0NB20+2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbgK3DGc (ORCPT ); Sun, 29 Nov 2020 22:06:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:22279 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbgK3DGc (ORCPT ); Sun, 29 Nov 2020 22:06:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606705506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=na0VqByCBLwL2XYwDNtC+dq1b+zzL7qMGmJPR1qmUks=; b=N0NB20+2+OaxAkC1bCFozDOssgyXP5eezCaFmkn3HR7tgKxna8AVDl2Euxo/dqfzKA4AKq OfIyDoBFCu75CZ2f+Y1AEBBU6ecIWl+zD+Ujm/Jj0YIDtYDNF+zL6ixnDAY4xW1F5uP4gK KtST5Qv2i0FpkyOCA057W/89TZ3IdhA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-y7BAwqydM9uuLIM8QSFasA-1; Sun, 29 Nov 2020 22:05:02 -0500 X-MC-Unique: y7BAwqydM9uuLIM8QSFasA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EEE771842142; Mon, 30 Nov 2020 03:05:00 +0000 (UTC) Received: from [10.72.13.173] (ovpn-13-173.pek2.redhat.com [10.72.13.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3D2DC1A88F; Mon, 30 Nov 2020 03:04:50 +0000 (UTC) Subject: Re: [PATCH v2 02/17] vdpa_sim: remove unnecessary headers inclusion To: Stefano Garzarella , virtualization@lists.linux-foundation.org Cc: Stefan Hajnoczi , linux-kernel@vger.kernel.org, Laurent Vivier , Max Gurtovoy , "Michael S. Tsirkin" , Eli Cohen References: <20201126144950.92850-1-sgarzare@redhat.com> <20201126144950.92850-3-sgarzare@redhat.com> From: Jason Wang Message-ID: Date: Mon, 30 Nov 2020 11:04:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201126144950.92850-3-sgarzare@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/26 下午10:49, Stefano Garzarella wrote: > Some headers are not necessary, so let's remove them to do > some cleaning. > > Signed-off-by: Stefano Garzarella > --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index 6a90fdb9cbfc..c6eaf62df8ec 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -7,24 +7,11 @@ > * > */ > > -#include > #include > -#include I think the rule is to make sure e.g the structure definition can be via direct inclusion. E.g struct device {} is defined in this file. > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > #include > -#include > -#include > #include > #include > #include > -#include And the  __cpu_to_virtio16 is defined in this file. Thanks > #include > #include > #include