From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05703C76188 for ; Fri, 19 Jul 2019 10:57:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C900E21855 for ; Fri, 19 Jul 2019 10:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="WV7GmmB2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727577AbfGSK5o (ORCPT ); Fri, 19 Jul 2019 06:57:44 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:34332 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbfGSK5o (ORCPT ); Fri, 19 Jul 2019 06:57:44 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x6JAvNAx059571; Fri, 19 Jul 2019 05:57:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1563533843; bh=e9BGRW2+AOOjzCcl3h71zGtY2pYY0ecnAlgV2kvpSCc=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=WV7GmmB2tn+MyIA2xtlbs49BX1bLYllkU/9wBq75rO+4M1bphWMbv+v6UrRvaoGkL bLZTqoIOnXz9vKXqExq0oDfVYRT/zDlMD0xGfG/OK1+zOZUvq629+2oUSgpctwyoi0 J+QWJRYxbD2lPOqto+JGPHcaDtJEuTYUSZzVr/VM= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x6JAvNco063487 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 19 Jul 2019 05:57:23 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 19 Jul 2019 05:57:22 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 19 Jul 2019 05:57:22 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x6JAvGr8021490; Fri, 19 Jul 2019 05:57:17 -0500 Subject: Re: [RFC PATCH 23/30] of/platform: Export of_platform_device_create_pdata() From: Kishon Vijay Abraham I To: Rob Herring , Lorenzo Pieralisi CC: Tom Joseph , Bjorn Helgaas , Mark Rutland , Arnd Bergmann , Gustavo Pimentel , Greg Kroah-Hartman , Frank Rowand , Jingoo Han , , , "linux-kernel@vger.kernel.org" , linux-omap , "open list:ARM/Rockchip SoC..." , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" References: <20190604131516.13596-1-kishon@ti.com> <20190604131516.13596-24-kishon@ti.com> Message-ID: Date: Fri, 19 Jul 2019 16:25:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lorenzo, On 11/06/19 10:08 AM, Kishon Vijay Abraham I wrote: > Hi Rob, > > On 10/06/19 11:13 PM, Rob Herring wrote: >> On Tue, Jun 4, 2019 at 7:19 AM Kishon Vijay Abraham I wrote: >>> >>> Export of_platform_device_create_pdata() to be used by drivers to >>> create child devices with the given platform data. This can be used >>> by platform specific driver to send platform data core driver. For e.g., >>> this will be used by TI's J721E SoC specific PCIe driver to send >>> ->start_link() ops and ->is_link_up() ops to Cadence core PCIe driver. >> >> NAK >> >> of_platform_device_create_pdata() is purely for legacy handling of >> auxdata which is something I hope to get rid of someday. Or to put it >> another way, auxdata use is a sign of platforms not fully converted to >> DT. > > All right. Thanks for letting me know your thoughts. > > Lorenzo, > > We've modeled Cadence PCIe core as a separate driver and for some of the > functionalities (for example starting LTSSM or checking link status) it has to > invoke the wrapper driver functions (The registers for these are present in > wrapper and not in Cadence Core). In the case of Designware, we modeled DWC > core as a library which provided APIs to be used by wrapper driver. Now that > Rob is not inclined for passing platform data from one driver to another (in > this case TI specific J721E driver to Cadence PCIe driver), should we model > Cadence core also as a library? If you agree, I can prepare patches for making > Cadence PCIe core as a library. Please let me know your thoughts. Can you share your thoughts on this? Thanks Kishon