Re: [PATCH 2/2] drm/panel: novatek-nt36523: use devm_drm_panel_add()

[Christophe JAILLET <christophe.jaillet@wanadoo.fr>]

Le 24/05/2026 à 18:36, Myeonghun Pak a écrit :
> nt36523_probe() adds the DRM panel before attaching the DSI devices. If
> one of the devm_mipi_dsi_attach() calls fails, probe returns with the
> panel still registered.
> 
> This issue was identified during our ongoing static-analysis research while
> reviewing kernel code.
> 
> Fixes: 0993234a0045 ("drm/panel: Add driver for Novatek NT36523")
> Cc: stable@vger.kernel.org
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> ---
>   drivers/gpu/drm/panel/panel-novatek-nt36523.c | 12 +++---------
>   1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> index 226d91daf8..f6592b01df 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> @@ -1047,13 +1047,6 @@ static int nt36523_unprepare(struct drm_panel *panel)
>   	return 0;
>   }
>   
> -static void nt36523_remove(struct mipi_dsi_device *dsi)
> -{
> -	struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);

Hi,

Not looked in details, but the:
	mipi_dsi_set_drvdata(dsi, pinfo);
in the probe now looks useless.

CJ

> -
> -	drm_panel_remove(&pinfo->panel);
> -}
> -
>   static int nt36523_get_modes(struct drm_panel *panel,
>   			       struct drm_connector *connector)
>   {
> @@ -1225,7 +1218,9 @@ static int nt36523_probe(struct mipi_dsi_device *dsi)
>   			return dev_err_probe(dev, ret, "Failed to get backlight\n");
>   	}
>   
> -	drm_panel_add(&pinfo->panel);
> +	ret = devm_drm_panel_add(dev, &pinfo->panel);
> +	if (ret)
> +		return ret;
>   
>   	for (i = 0; i < DSI_NUM_MIN + pinfo->desc->is_dual_dsi; i++) {
>   		pinfo->dsi[i]->lanes = pinfo->desc->lanes;
> @@ -1259,7 +1254,6 @@ MODULE_DEVICE_TABLE(of, nt36523_of_match);
>   
>   static struct mipi_dsi_driver nt36523_driver = {
>   	.probe = nt36523_probe,
> -	.remove = nt36523_remove,
>   	.driver = {
>   		.name = "panel-novatek-nt36523",
>   		.of_match_table = nt36523_of_match,