From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8965BC4320A for ; Tue, 24 Aug 2021 17:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EE50610D1 for ; Tue, 24 Aug 2021 17:42:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241959AbhHXRnk (ORCPT ); Tue, 24 Aug 2021 13:43:40 -0400 Received: from linux.microsoft.com ([13.77.154.182]:38450 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242262AbhHXRlk (ORCPT ); Tue, 24 Aug 2021 13:41:40 -0400 Received: from [192.168.254.32] (unknown [47.187.212.181]) by linux.microsoft.com (Postfix) with ESMTPSA id ACBD920B85E3; Tue, 24 Aug 2021 10:40:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ACBD920B85E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1629826855; bh=iEH5ZkCYlu4MLwDsXaWAUZTZ3u76InpKPQIAJ+tahCQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ULQYwR/HDrdutfZuWoBYjv9J+K9Ajv4mdI+RS8hF1D0bPirfKKirW3dyTu0hkjIDy w1brU4AdqF15GjIRR592ogXMq412yRkEUK2wwErTLABjjlQzJUQHIa1om4SgSnEUB3 h5ZnMjbHcDGnNq/F1uUzywYcsWGj0+GEz5P5703k= Subject: Re: [RFC PATCH v8 1/4] arm64: Make all stack walking functions use arch_stack_walk() To: Mark Brown Cc: Mark Rutland , jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210812190603.25326-1-madvenka@linux.microsoft.com> <20210812190603.25326-2-madvenka@linux.microsoft.com> <20210824131344.GE96738@C02TD0UTHF1T.local> <20210824173850.GN4393@sirena.org.uk> From: "Madhavan T. Venkataraman" Message-ID: Date: Tue, 24 Aug 2021 12:40:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210824173850.GN4393@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/21 12:38 PM, Mark Brown wrote: > On Tue, Aug 24, 2021 at 12:21:28PM -0500, Madhavan T. Venkataraman wrote: >> On 8/24/21 8:13 AM, Mark Rutland wrote: >>> On Thu, Aug 12, 2021 at 02:06:00PM -0500, madvenka@linux.microsoft.com wrote: > >>> Note that arch_stack_walk() depends on CONFIG_STACKTRACE (which is not in >>> defconfig), so we'll need to reorganise things such that it's always defined, >>> or factor out the core of that function and add a wrapper such that we >>> can always use it. > >> I will include CONFIG_STACKTRACE in defconfig, if that is OK with you and >> Mark Brown. > > That might be separately useful but it doesn't address the issue, if > something is optional we need to handle the case where that option is > disabled. It'll need to be one of the two options Mark Rutland > mentioned above. > OK. I will do it so it is always defined. Thanks. Madhavan