mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Wang YanQing <udknight@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-realtek-soc@lists.infradead.org,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will.deacon@arm.com>
Subject: Re: perf record doesn't work on rtd129x SoC
Date: Wed, 4 Dec 2019 08:28:26 +0100	[thread overview]
Message-ID: <f90748d0-8112-3aa8-0c88-e35a8d6e72d3@suse.de> (raw)
In-Reply-To: <20191204045559.GA10458@udknight>

Hi YanQing,

+ LAKML + Mark + Will

Am 04.12.19 um 05:55 schrieb Wang YanQing:
> I use "perf record" to debug performance issue on RTD1296 SOC, it does't work, but
> the "perf stat" is ok!

Thanks for the report - which board, branch and (base) tag are you
testing against? And are you building perf yourself from kernel sources,
or are you using some distro package?

I only have Busybox in my initrd on DS418; I have not tested perf.

> After some dig in the kernel, I find the reason is no pmu overflow interrupt, I think
> below pmu configuration isn't right for RTD1296:
> "
>         arm_pmu: arm-pmu {
>                 compatible = "arm,cortex-a53-pmu";
>                 interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
>         };
> "
> 
> We need 4 PMU SPI for RTD1296 (4 cores), and I guess the 48 isn't right too.

Note that above rtd129x.dtsi snippet is not complete. See rtd1296.dtsi:

&arm_pmu {
	interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
};

48 and high/4 match what I see in the latest BSP:

https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/arch/arm64/boot/dts/realtek/rtd129x/rtd-1296.dtsi#L116

> Any suggestion is welcome.
> 
> Thanks!

The only difference I see is "arm,cortex-a53-pmu" vs. "arm,armv8-pmuv3".
By my reading of arch/arm64/kernel/perf_event.c the only difference
between the two should be the name and an extra cache_map. You could try
the other compatible string in your .dts, but I doubt it'll help.

Hopefully the Realtek or Arm guys can shed some light.

Regards,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

  reply	other threads:[~2019-12-04  7:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  4:55 Wang YanQing
2019-12-04  7:28 ` Andreas Färber [this message]
2019-12-04 11:20   ` Robin Murphy
2019-12-04 11:38     ` Marc Zyngier
2019-12-04 14:51     ` Robin Murphy
2019-12-09  9:18       ` Wang YanQing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f90748d0-8112-3aa8-0c88-e35a8d6e72d3@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=udknight@gmail.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®