From: Keerthy <j-keerthy@ti.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] regulator: lp87565: Fix missing register for LP87565_BUCK_0
Date: Wed, 13 Mar 2019 10:26:46 +0530 [thread overview]
Message-ID: <f90d4497-a174-352b-6f1e-0b8de19088ec@ti.com> (raw)
In-Reply-To: <20190301061640.28921-1-axel.lin@ingics.com>
On 01/03/19 11:46 AM, Axel Lin wrote:
> LP87565_BUCK_0 is missed, fix it.
>
> Fixes: f0168a9bf ("regulator: lp87565: Add support for lp87565 PMIC regulators")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi J Keerthy,
> While reading the code, it seems strange that LP87565_BUCK_0 is never used.
> So current code only register 3 BUCKs for lp87565-regulator.
> Can you confirm if this fix is correct or not?
Axel,
If you look at the if check later:
if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
Currently the device that i am using only uses LP87565_BUCK_10 and
LP87565_BUCK_23(dual phase).
So your patch definitely makes sense when all 4 are used individually.
Thanks for catching this.
Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> Thanks,
> Axel
> drivers/regulator/lp87565-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
> index 4ed41731a5b1..0418e478c6dc 100644
> --- a/drivers/regulator/lp87565-regulator.c
> +++ b/drivers/regulator/lp87565-regulator.c
> @@ -193,7 +193,7 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
> struct lp87565 *lp87565 = dev_get_drvdata(pdev->dev.parent);
> struct regulator_config config = { };
> struct regulator_dev *rdev;
> - int i, min_idx = LP87565_BUCK_1, max_idx = LP87565_BUCK_3;
> + int i, min_idx = LP87565_BUCK_0, max_idx = LP87565_BUCK_3;
>
> platform_set_drvdata(pdev, lp87565);
>
>
prev parent reply other threads:[~2019-03-13 4:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 6:16 Axel Lin
2019-03-13 4:56 ` Keerthy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f90d4497-a174-352b-6f1e-0b8de19088ec@ti.com \
--to=j-keerthy@ti.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®