From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755044AbcH3Hds (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 03:33:48 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:31727 "EHLO
        mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751606AbcH3Hdq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 03:33:46 -0400
X-AuditID: cbfec7f5-f792e6d0000013f5-bb-57c536d66586
Subject: Re: [PATCH 3/4] ARM: dts: add fimc support in exynos4412 TOPEET iTop
 Elite board
To: Randy Li <ayaka@soulik.info>, devicetree@vger.kernel.org
References: <CAL_JsqKY=VEZ+U11kY+XbMWuXhaFDr6GpnR3AXKd1U=9_=8fgA@mail.gmail.com>
 <1472383269-3126-1-git-send-email-ayaka@soulik.info>
 <1472383269-3126-4-git-send-email-ayaka@soulik.info>
Cc: mark.rutland@arm.com, linux@armlinux.org.uk, kgene@kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        robh@kernel.org
From: Krzysztof Kozlowski <krzk@kernel.org>
Message-id: <f90ffaf4-dc95-9c32-1f4d-771f96424783@kernel.org>
Date: Tue, 30 Aug 2016 09:33:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-version: 1.0
In-reply-to: <1472383269-3126-4-git-send-email-ayaka@soulik.info>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsVy+t/xK7rXzI6GG8xtlrJ4dfcXo8X8I+dY
        LV6/MLTof/ya2WLT42usFpd3zWGzmHF+H5PFoal7GS2WXr/IZPF/zw52By6PNfPWMHpcvnaR
        2WPTqk42j81L6j36tqxi9Gi+O53V4/MmuQD2KC6blNSczLLUIn27BK6Mrb/2MhW85qp40HmI
        tYHxPkcXIyeHhICJxJ3W5awQtpjEhXvr2boYuTiEBJYySjQtu80I4TxjlFg3YRMzSJWwQLTE
        urebGEFsEQEbiWdLVrBCFB1glFi29wIziMMssJdRYsnMq0AOBwebgLbEvy3FICavgK3E/2PO
        IL0sAqoS0xesYgexRQUiJG6t+gg2k1dAUOLH5HssIDangKPEp4/HWEFamQX0JO5f1AIJMwvI
        S2xe85Z5AqPALCQdsxCqZiGpWsDIvIpRNLU0uaA4KT3XSK84Mbe4NC9dLzk/dxMjJCK+7mBc
        eszqEKMAB6MSD+8ElyPhQqyJZcWVuYcYJTiYlUR4+w2PhgvxpiRWVqUW5ccXleakFh9ilOZg
        URLnnbnrfYiQQHpiSWp2ampBahFMlomDU6qB0b57gfzhS0/MTVlCzh7q83o280VEX7ri2wSH
        f6La7Nd55qjsU/sf9Cbf9cm9aYtfGsnt193VGrJ035UNa+/ZNVy7ZOXY5KVgGX/8Rtfj0HCx
        bffqth7rrIpbumyJ00mGnTeF3h7YZn5yW9L3j63dDF+WHy3deXRBjuOnxJ4wbaboU7/3zPhx
        XlCJpTgj0VCLuag4EQAM3w2IhAIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/28/2016 01:21 PM, Randy Li wrote:
> The is not used for camera, I enabled it just for a colorspace
> convertor.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  arch/arm/boot/dts/exynos4412-itop-elite.dts | 16 ++++++++++++++++

This should be squashed with patch #2.

BTW, please add also vendor prefix
(Documentation/devicetree/bindings/vendor-prefixes.txt).

Best regards,
Krzysztof

>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> index 5688589..2d11b9a 100644
> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> @@ -82,6 +82,14 @@
>  		pinctrl-0 = <&pwm0_out>;
>  		pinctrl-names = "default";
>  	};
> +
> +	camera: camera {
> +		pinctrl-0 = <&cam_port_a_clk_active>;
> +		pinctrl-names = "default";
> +		status = "okay";
> +		assigned-clocks = <&clock CLK_MOUT_CAM0>;
> +		assigned-clock-parents = <&clock CLK_XUSBXTI>;
> +	};
>  };
>  
>  &pinctrl_1 {
> @@ -146,3 +154,11 @@
>  	vdd-supply = <&ldo3_reg>;
>  	status = "okay";
>  };
> +
> +&fimc_0 {
> +	status = "okay";
> +	assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> +			<&clock CLK_SCLK_FIMC0>;
> +	assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> +	assigned-clock-rates = <0>, <176000000>;
> +};
>