From: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
To: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] slimbus: qcom-ngd-ctrl: Implement disable_stream callback
Date: Tue, 11 Aug 2026 10:43:15 +0530 [thread overview]
Message-ID: <f9104bfe-4016-4394-a895-a392fdcde59c@oss.qualcomm.com> (raw)
In-Reply-To: <20260810-slim-disable-stream-support-v2-1-c2e8fcc3c99d@oss.qualcomm.com>
On 8/10/2026 11:22 PM, Viken Dadhaniya wrote:
> Switching a channel to a new frequency without first disabling the stream
> causes the channel to be re-enabled without a clean shutdown, leading to a
> crash on the DSP subsystem.
>
> Implement qcom_slim_ngd_disable_stream() so clients can properly close a
> channel before switching to a new frequency.
>
Better subject name would be "Prevent DSP crash during channel frequency
switch", it highlights the issue fix.
Rest looks fine.
> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
> ---
Acked-by : Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
next prev parent reply other threads:[~2026-08-11 5:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 17:52 Viken Dadhaniya
2026-08-11 5:13 ` Mukesh Savaliya [this message]
[not found] ` <da616225-4be1-4c28-adcb-c32e392703cc@oss.qualcomm.com>
2026-08-17 9:22 ` Mukesh Savaliya
2026-09-17 22:35 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9104bfe-4016-4394-a895-a392fdcde59c@oss.qualcomm.com \
--to=mukesh.savaliya@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=srini@kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®