RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

["Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>]

> Subject: Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of()
> code
> 
> On Tue, Dec 31, 2013 at 03:27:53AM +0000, Li.Xiubo@freescale.com wrote:
> 
> > Also, for most of the devices of the same DAI link, they use the same DAI
> > formats, but I have found some drivers like : "sound/soc/pxa/magician.c"
> > and "sound/soc/s6000/s6105-ipcam.c", etc, may have different DAI format
> > settings for some reasons(maybe some formats are the CPU/Codec devices
> > default setting that it needn't set it here or others).
> 
> The ipcam still has that?  

	-----------
        /* set codec DAI configuration */
        ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |
                                             SND_SOC_DAIFMT_CBM_CFM);
        if (ret < 0)
                return ret;

        /* set cpu DAI configuration */
        ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_CBM_CFM |
                                           SND_SOC_DAIFMT_NB_NF);
        if (ret < 0)
                return ret;
	----------

 ... ?

> 
> > I think maybe this is also the reason why the simple-card has common DAI
> > format and CPU/CODEC private DAI formats at the same time.
> 
> I'd really want to see a real use case that actually was a simple card.

I'm also still trying.


Thanks,

--
Best Regards,
Xiubo