From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751976AbdEELqc (ORCPT <rfc822;w@1wt.eu>);
        Fri, 5 May 2017 07:46:32 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:39198 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751157AbdEELqa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 May 2017 07:46:30 -0400
Subject: Re: [PATCH v2] sd: Ignore sync cache failures when not supported
To: Christoph Hellwig <hch@infradead.org>
References: <1493891010-24258-1-git-send-email-thierry.escande@collabora.com>
 <20170505090201.GA31209@infradead.org>
Cc: Bart Van Assche <Bart.VanAssche@sandisk.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
From: Thierry Escande <thierry.escande@collabora.com>
Message-ID: <f9129c8a-de72-eb16-7e56-0003ddbacf27@collabora.com>
Date: Fri, 5 May 2017 13:46:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170505090201.GA31209@infradead.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/05/2017 11:02, Christoph Hellwig wrote:
> Normally we'd just pass the scsi_sense_hdr structure in from the
> caler if we care about sense data.  Is this something you considered?
Not really as only the sense_key field is needed for only one call to 
sd_sync_cache() (out of two).

>
> Otherwise this looks fine to me.
>