From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3412C83F1E for ; Wed, 30 Aug 2023 19:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243809AbjH3TZP (ORCPT ); Wed, 30 Aug 2023 15:25:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241797AbjH3HHr (ORCPT ); Wed, 30 Aug 2023 03:07:47 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FB6195 for ; Wed, 30 Aug 2023 00:07:44 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RbFjl0RS7z4f3nbx for ; Wed, 30 Aug 2023 15:07:39 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP3 (Coremail) with SMTP id _Ch0CgD3Eru76u5kEDVABw--.65276S2; Wed, 30 Aug 2023 15:07:40 +0800 (CST) Subject: Re: [PATCH v2 5/7] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable To: Mel Gorman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-6-shikemeng@huaweicloud.com> <20230829150523.ktn6ktdtl7n22akp@techsingularity.net> From: Kemeng Shi Message-ID: Date: Wed, 30 Aug 2023 15:07:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20230829150523.ktn6ktdtl7n22akp@techsingularity.net> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-CM-TRANSID: _Ch0CgD3Eru76u5kEDVABw--.65276S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtrW5tr1kJry7tF43trW5Jrb_yoW3Crc_Gr 1F9rs7CrWUAw1kJFyayrnxursYgayUAF1UuryrKayYga45WrZ5Jws7J3W7ZF48JrWUuFy0 93Wfur45CFWjqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb78YFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAK I48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw2 0EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY 1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IUbPEf5UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on 8/29/2023 11:05 PM, Mel Gorman wrote: > On Sat, Aug 26, 2023 at 11:36:15PM +0800, Kemeng Shi wrote: >> We have compact_blockskip_flush check in __reset_isolation_suitable, just >> remove repeat check before __reset_isolation_suitable in >> compact_blockskip_flush. >> >> Signed-off-by: Kemeng Shi >> Reviewed-by: Baolin Wang > > The comment should move to __reset_isolation_suitable but otherwise > Thanks for the review, I will move comment in next version. > Acked-by: Mel Gorman > > As a complete aside, the reset_isolation_suitable and > __reset_isolation_suitable were badly named because locking is not > involved but it's meaningless churn to fix it. >