From: Shuah Khan <skhan@linuxfoundation.org>
To: Antonio Borneo <borneo.antonio@gmail.com>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hewenliang <hewenliang4@huawei.com>,
linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH] usbip: tools: fix build error for multiple definition
Date: Thu, 18 Jun 2020 11:36:39 -0600 [thread overview]
Message-ID: <f914d6a1-20d6-2e00-bcf5-658848ad95a1@linuxfoundation.org> (raw)
In-Reply-To: <20200618000844.1048309-1-borneo.antonio@gmail.com>
On 6/17/20 6:08 PM, Antonio Borneo wrote:
> With GCC 10, building usbip triggers error for multiple definition
> of 'udev_context', in:
> - libsrc/vhci_driver.c:18 and
> - libsrc/usbip_host_common.c:27.
>
> Declare as extern the definition in libsrc/usbip_host_common.c.
>
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> ---
> tools/usb/usbip/libsrc/usbip_host_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/usb/usbip/libsrc/usbip_host_common.c b/tools/usb/usbip/libsrc/usbip_host_common.c
> index d1d8ba2a4a40..ca78aa368476 100644
> --- a/tools/usb/usbip/libsrc/usbip_host_common.c
> +++ b/tools/usb/usbip/libsrc/usbip_host_common.c
> @@ -23,7 +23,7 @@
> #include "list.h"
> #include "sysfs_utils.h"
>
> -struct udev *udev_context;
> +extern struct udev *udev_context;
>
> static int32_t read_attr_usbip_status(struct usbip_usb_device *udev)
> {
>
Looks good to me.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2020-06-18 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 0:08 Antonio Borneo
2020-06-18 17:36 ` Shuah Khan [this message]
2020-07-23 22:58 ` Salvatore Bonaccorso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f914d6a1-20d6-2e00-bcf5-658848ad95a1@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=borneo.antonio@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hewenliang4@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®