From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754906AbcKJJOV (ORCPT ); Thu, 10 Nov 2016 04:14:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:58321 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbcKJJOT (ORCPT ); Thu, 10 Nov 2016 04:14:19 -0500 Subject: Re: [Xen PATCH] xen-netback: fix error handling output To: Arnd Bergmann , David Vrabel References: <20161108133449.1649345-1-arnd@arndb.de> Cc: Wei Liu , Paul Durrant , "David S. Miller" , Filipe Manco , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Juergen Gross Message-ID: Date: Thu, 10 Nov 2016 10:14:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161108133449.1649345-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/16 14:34, Arnd Bergmann wrote: > The connect function prints an unintialized error code after an > earlier initialization was removed: > > drivers/net/xen-netback/xenbus.c: In function 'connect': > drivers/net/xen-netback/xenbus.c:938:3: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This prints it as -EINVAL instead, which seems to be the most > appropriate error code. Before the patch that caused the warning, > this would print a positive number returned by vsscanf() instead, > which is also wrong. We probably don't need a backport though, > as fixing the warning here should be sufficient. > > Fixes: f95842e7a9f2 ("xen: make use of xenbus_read_unsigned() in xen-netback") > Fixes: 8d3d53b3e433 ("xen-netback: Add support for multiple queues") > Signed-off-by: Arnd Bergmann Applied to xen/tip.git for-linus-4.10 Thanks, Juergen > --- > drivers/net/xen-netback/xenbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c > index 7356e00fac54..bfed79877b8a 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -935,7 +935,7 @@ static void connect(struct backend_info *be) > "multi-queue-num-queues", 1); > if (requested_num_queues > xenvif_max_queues) { > /* buggy or malicious guest */ > - xenbus_dev_fatal(dev, err, > + xenbus_dev_fatal(dev, -EINVAL, > "guest requested %u queues, exceeding the maximum of %u.", > requested_num_queues, xenvif_max_queues); > return; >