mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Subject: Re: [PATCH] media: vsp1: mask interrupts before enabling
Date: Wed, 20 Oct 2021 20:45:50 +0300	[thread overview]
Message-ID: <f91c4f16-fd81-5d70-0146-e9aa2d128da9@cogentembedded.com> (raw)
In-Reply-To: <163455832550.1371157.18009256492359430197@Monstersaurus>

Hi,

> Could you test to see if those lines to explicitly set VI6_DISP_IRQ_ENB
> and VI6_WPF_IRQ_ENB are really needed in your use case please?

Commenting out those register writes causes

[    2.275137][    C0] irq 188: nobody cared (try booting with the "irqpoll" option)
[    2.282621][    C0] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.15.0-rc5 #28
[    2.289669][    C0] Hardware name: Renesas H3ULCB Kingfisher board based on r8a77951 (DT)
[    2.297844][    C0] Call trace:
[    2.300981][    C0]  dump_backtrace+0x0/0x198
[    2.305348][    C0]  show_stack+0x1c/0x28
[    2.309357][    C0]  dump_stack_lvl+0x64/0x7c
[    2.313718][    C0]  dump_stack+0x14/0x2c
[    2.317725][    C0]  __report_bad_irq+0x50/0xdc
[    2.322254][    C0]  note_interrupt+0x2e4/0x330
[    2.326786][    C0]  handle_irq_event_percpu+0x58/0x68
[    2.331927][    C0]  handle_irq_event+0x4c/0x98
[    2.336456][    C0]  handle_fasteoi_irq+0xd0/0x180
[    2.341245][    C0]  handle_domain_irq+0x94/0xd8
[    2.345862][    C0]  gic_handle_irq+0xa4/0xe0
[    2.350216][    C0]  do_interrupt_handler+0x38/0x60
[    2.355093][    C0]  el1_interrupt+0x2c/0x68
[    2.359362][    C0]  el1h_64_irq_handler+0x14/0x20
[    2.364151][    C0]  el1h_64_irq+0x74/0x78
[    2.368244][    C0]  __do_softirq+0xc8/0x404
[    2.372511][    C0]  irq_exit+0x118/0x140
[    2.376521][    C0]  handle_domain_irq+0x98/0xd8
[    2.381137][    C0]  gic_handle_irq+0xa4/0xe0
[    2.385490][    C0]  call_on_irq_stack+0x28/0x3c
[    2.390105][    C0]  do_interrupt_handler+0x54/0x60
[    2.394981][    C0]  el1_interrupt+0x2c/0x68
[    2.399247][    C0]  el1h_64_irq_handler+0x14/0x20
[    2.404036][    C0]  el1h_64_irq+0x74/0x78
[    2.408129][    C0]  _raw_spin_unlock_irqrestore+0x20/0x50
[    2.413615][    C0]  __setup_irq+0x56c/0x888
[    2.417882][    C0]  request_threaded_irq+0xf0/0x1a8
[    2.422843][    C0]  devm_request_threaded_irq+0x84/0xf8
[    2.428155][    C0]  vsp1_probe+0x218/0xb48
[    2.432340][    C0]  platform_probe+0x6c/0xd8
[    2.436700][    C0]  really_probe+0xc0/0x428
[    2.440967][    C0]  __driver_probe_device+0x114/0x188
[    2.446103][    C0]  driver_probe_device+0x44/0xe8
[    2.450891][    C0]  __driver_attach+0xbc/0x1a0
[    2.455419][    C0]  bus_for_each_dev+0x64/0xa0
[    2.459947][    C0]  driver_attach+0x28/0x30
[    2.464215][    C0]  bus_add_driver+0x144/0x228
[    2.468743][    C0]  driver_register+0x68/0x118
[    2.473272][    C0]  __platform_driver_register+0x2c/0x38
[    2.478669][    C0]  vsp1_platform_driver_init+0x20/0x28
[    2.483985][    C0]  do_one_initcall+0x38/0x258
[    2.488513][    C0]  kernel_init_freeable+0x228/0x28c
[    2.493565][    C0]  kernel_init+0x28/0x120
[    2.497745][    C0]  ret_from_fork+0x10/0x20
[    2.502013][    C0] handlers:
[    2.504974][    C0] [<0000000040be598b>] vsp1_irq_handler
[    2.510376][    C0] Disabling IRQ #188

Nikita

  reply	other threads:[~2021-10-20 17:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 15:53 Nikita Yushchenko
2021-10-18 11:58 ` Kieran Bingham
2021-10-20 17:45   ` Nikita Yushchenko [this message]
2021-11-02 11:13     ` Kieran Bingham
2021-12-13 20:13       ` Nikita Yushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f91c4f16-fd81-5d70-0146-e9aa2d128da9@cogentembedded.com \
    --to=nikita.yoush@cogentembedded.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=koji.matsuoka.xm@renesas.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®