From: Krzysztof Kozlowski <krzk@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@ew.tq-group.com
Subject: Re: [PATCH 1/4] i2c: machxo2: new driver
Date: Thu, 16 Oct 2025 07:44:56 +0200 [thread overview]
Message-ID: <f91f3c15-0070-413a-8f35-541149a07f0b@kernel.org> (raw)
In-Reply-To: <9e00b0ff4e90e4fb31c3012bd7a753d06ae21b45.1760525985.git.matthias.schiffer@ew.tq-group.com>
On 15/10/2025 13:03, Matthias Schiffer wrote:
> +
> +module_platform_driver(machxo2_i2c_driver);
> +
> +MODULE_AUTHOR("TQ-Systems GmbH <linux@ew.tq-group.com>");
> +MODULE_DESCRIPTION("Lattice MachXO2 I2C bus driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:i2c-machxo2");
You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-10-16 5:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 11:03 Matthias Schiffer
2025-10-15 11:03 ` [PATCH 2/4] mfd: tqmx86: refactor I2C setup Matthias Schiffer
2025-10-15 11:11 ` Matthias Schiffer
2025-10-15 11:03 ` [PATCH 3/4] mfd: tqmx86: add detection for MachXO2 I2C controller Matthias Schiffer
2025-10-15 11:03 ` [PATCH 4/4] mfd: tqmx86: add detection for secondary " Matthias Schiffer
2025-10-16 5:44 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f91f3c15-0070-413a-8f35-541149a07f0b@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=matthias.schiffer@ew.tq-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®