Re: [PATCH 0/2] media: uvcvideo: Enable keep-sorted

[Hans de Goede <hansg@kernel.org>]

Hi Ricardo,

On 29-Apr-25 15:47, Ricardo Ribalda wrote:
> When committers contribute quirks to the uvc driver, they usually add
> them out of order.
> 
> We can automatically validate that their follow our guidelines with the
> use of keep-sorted.
> 
> This patchset adds support for keep-sorted in the uvc driver. The two
> patches can be squashed if needed.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

I've no objections against these 2 patches, but these need to be
rebased on top of the latest uvc/for-next. Can you send out a new
version please ?

Also for patch 2/2 can we not just add the 2 keep-sorted headers
and then actually run keep-sorted to auto-fix things ?

Or can it not auto-fix ?

Regards,

Hans



> ---
> Ricardo Ribalda (2):
>       media: uvcvideo: Rewrite uvc_ids for keep-sorted.
>       media: uvcvideo: Add keep-sorted statement and sort uvc_ids
> 
>  drivers/media/usb/uvc/uvc_driver.c | 660 +++++++++++++++++++++++--------------
>  1 file changed, 409 insertions(+), 251 deletions(-)
> ---
> base-commit: 398a1b33f1479af35ca915c5efc9b00d6204f8fa
> change-id: 20250429-keep-sorted-2ac6f4796726
> 
> Best regards,