From: neil.armstrong@linaro.org
To: muhammed.efecetin.67@gmail.com, linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
lee@kernel.org, rafael@kernel.org, efectn@protonmail.com,
daniel.lezcano@linaro.org
Subject: Re: [PATCH 2/5] mfd: khadas-mcu: drop unused nvmem code
Date: Thu, 26 Jun 2025 16:07:11 +0200 [thread overview]
Message-ID: <f92836f5-c81a-4bfd-a77f-903e74452c59@linaro.org> (raw)
In-Reply-To: <1b421ddfd44d096cd3a979462ced002e2356eb21.1746518265.git.efectn@protonmail.com>
On 26/06/2025 16:04, muhammed.efecetin.67@gmail.com wrote:
> From: Muhammed Efe Cetin <efectn@protonmail.com>
>
> Drop "khadas-mcu-user-mem" code since it is not used anywhere.
>
> Signed-off-by: Muhammed Efe Cetin <efectn@protonmail.com>
> ---
> drivers/mfd/khadas-mcu.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/mfd/khadas-mcu.c b/drivers/mfd/khadas-mcu.c
> index ba981a788..ca4bd6cf5 100644
> --- a/drivers/mfd/khadas-mcu.c
> +++ b/drivers/mfd/khadas-mcu.c
> @@ -80,10 +80,6 @@ static struct mfd_cell khadas_mcu_fan_cells[] = {
> { .name = "khadas-mcu-fan-ctrl", },
> };
>
> -static struct mfd_cell khadas_mcu_cells[] = {
> - { .name = "khadas-mcu-user-mem", },
> -};
> -
> static int khadas_mcu_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> @@ -105,13 +101,6 @@ static int khadas_mcu_probe(struct i2c_client *client)
> return ret;
> }
>
> - ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> - khadas_mcu_cells,
> - ARRAY_SIZE(khadas_mcu_cells),
> - NULL, 0, NULL);
> - if (ret)
> - return ret;
> -
> if (of_property_present(dev->of_node, "#cooling-cells"))
> return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> khadas_mcu_fan_cells,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2025-06-26 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 14:04 [PATCH 0/5] Add Khadas MCU and fan control support for Khadas Edge 2 muhammed.efecetin.67
2025-06-26 14:04 ` [PATCH 1/5] dt-bindings: mfd: khadas-mcu: add cooling-levels property muhammed.efecetin.67
2025-06-26 14:12 ` neil.armstrong
2025-06-26 14:04 ` [PATCH 2/5] mfd: khadas-mcu: drop unused nvmem code muhammed.efecetin.67
2025-06-26 14:07 ` neil.armstrong [this message]
2025-06-26 14:04 ` [PATCH 3/5] mfd: khadas-mcu: add Khadas Edge 2 registers muhammed.efecetin.67
2025-06-26 14:13 ` neil.armstrong
2025-06-26 14:04 ` [PATCH 4/5] thermal: khadas_mcu_fan: add support for Khadas Edge 2 muhammed.efecetin.67
2025-06-26 14:11 ` neil.armstrong
2025-06-26 14:36 ` muhammed.efecetin.67
2025-06-26 14:46 ` neil.armstrong
2025-06-26 15:16 ` Muhammed Efe Cetin
2025-06-26 15:29 ` neil.armstrong
2025-06-26 14:04 ` [PATCH 5/5] arm64: dts: rockchip: add Khadas MCU and fan control nodes muhammed.efecetin.67
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92836f5-c81a-4bfd-a77f-903e74452c59@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=efectn@protonmail.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=muhammed.efecetin.67@gmail.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®