From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4442CC433E0 for ; Fri, 5 Jun 2020 06:09:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13B9E2081A for ; Fri, 5 Jun 2020 06:09:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="pT7K+wZx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbgFEGJO (ORCPT ); Fri, 5 Jun 2020 02:09:14 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:12904 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbgFEGJK (ORCPT ); Fri, 5 Jun 2020 02:09:10 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 04 Jun 2020 23:08:57 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 04 Jun 2020 23:09:09 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 04 Jun 2020 23:09:09 -0700 Received: from [10.26.75.201] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 5 Jun 2020 06:09:06 +0000 Subject: Re: [PATCH] spi: tegra114: missing put on pm_runtime_get_sync failure To: Navid Emamdoost , Laxman Dewangan , Mark Brown , Thierry Reding , , , CC: , , , References: <20200602045506.40574-1-navid.emamdoost@gmail.com> From: Jon Hunter Message-ID: Date: Fri, 5 Jun 2020 07:09:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200602045506.40574-1-navid.emamdoost@gmail.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1591337337; bh=Fs5owMcBXZxBEaKBbscTgxeCUWoaivJ3Phc/NIsnyRA=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=pT7K+wZxTxAM/7Fb/3IhfkqXAJjNb8HdOJ8Fo2q+92NqX/+HJ09awi4kcZJvoCcup 7W8bIKNxyWNXUa59jz+N2/L746R7Acm1dva9z6HdRYG8TEpiH6AhCN2k6YpQGiz4UJ 7hlv0uO4OTkx3lINoHLtJdgRp63wRkxr8/km/em+Zm7VkMSTXLN97oRXZcJMI8BriF 6BTHlzUwl3gGgB15bsJ5KwIRwGZJRy8mK4DV2hHFVG9+hqK324dzqpjLjbiZKAST6n jRVIbHYRGmQeuIPFwnsVuLCHBteUUveQFwsJZFtZeR/oaDu1PtLQ+YRl0Tp8brpRUR U0s+MaSlg7Tbg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2020 05:55, Navid Emamdoost wrote: > the call to pm_runtime_get_sync increments the counter even > in case of failure leading to incorrect ref count. > Call pm_runtime_put if pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost > --- > drivers/spi/spi-tegra114.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c > index 83edabdb41ad..dccd2ac1a975 100644 > --- a/drivers/spi/spi-tegra114.c > +++ b/drivers/spi/spi-tegra114.c > @@ -974,6 +974,7 @@ static int tegra_spi_setup(struct spi_device *spi) > dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret); > if (cdata) > tegra_spi_cleanup(spi); > + pm_runtime_put(tspi->dev); > return ret; > } > > @@ -1398,6 +1399,7 @@ static int tegra_spi_probe(struct platform_device *pdev) > ret = pm_runtime_get_sync(&pdev->dev); > if (ret < 0) { > dev_err(&pdev->dev, "pm runtime get failed, e = %d\n", ret); > + pm_runtime_put(&pdev->dev); > goto exit_pm_disable; > } I am wondering if it is better we use put_sync() here to ensure that this happens before we exit the probe. Jon -- nvpublic