From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00963347506 for ; Wed, 12 Aug 2026 12:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786538555; cv=none; b=pPICZov+wv1oA3QF2XYqUvvyvMKS0iCXw0yq0xnG6xeC1sAJrK+9WOtswEk8obw90ZSr/DAxOK4hiLKtWycUCppmFpZB82MIOOmX8vwMx8u3KdqcQ1qk9ExUGiLXkM3JS6eQ3tVDzA+gHi0h2QyJooL89d9ZcI4VmtrXSfTMGW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786538555; c=relaxed/simple; bh=HT6odfgIm31nAJlXlSvWqpoui4IahVtMLX93lrDvz0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jYfjXuVHoi8ZQsw3Xu7kWGflTp3UN8fKuNjJ3+QW9k85tdBKq6v0+2zdmZVk1SuUNxWxJ2Xx9PrGqL7+6R7+bNQW3292LpsbrGvB3s4DaerkcsRzRNYTmiPxkyZyT5W5vhbDaGc8HmldyO77fpnm1OjeK0dTQGHkIdesZZ6c3TI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bu0yGjTw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PzIQYkIV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bu0yGjTw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PzIQYkIV" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4eUd2396484 for ; Wed, 12 Aug 2026 12:42:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xJ9VAtOW4dvyLTFJEa/GHt4ssfJ12G8OyYzymmqsAo4=; b=bu0yGjTwPU+skCKe 8BcRSYnznUUuD/6w1Uc8YkK7lL3SaHWK8knn2W8SUaHNt7KJPNtE5VQQD28lODUR /YypukvxjsGI0gq7dWjAZq9sJpdN3vVWZkyM0JUOaP+p2tephTXzXOakodBX2tLK tK+yjGBVqJ0aZ5+m6bnmgAA6A5Wy/gm5HXiH343weEyOKnDfkXVG72LmK6XhtR5t /ALnWf+L8jx+8lqXL5//ACRzkIbzTz85vaZtnOktItKXIIHG9StSIEpBgjl8DWWT wyevSYWfYY1aErU9WjhkeCch0o7cdLNXMeXmLpcwVbnTGXRgKl0UVmmoovb577IM AxtpiQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0hfw1td7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 12:42:30 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e7b87ce77so2153636a91.0 for ; Wed, 12 Aug 2026 05:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786538549; x=1787143349; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xJ9VAtOW4dvyLTFJEa/GHt4ssfJ12G8OyYzymmqsAo4=; b=PzIQYkIVRgqculSy6QeBlNq3s2VvaB6mrAx6nYh/1xU7WEQSBMcAJKdmDxQjoPkTAA t2SofXHTUL7fRIzyp9Kzn7fFVRVCsGcg/ZFXQeHf6ntZiLIzDsmgZ6ci5xkykD7c0ZGQ G6XhUjYtBIKJl/L4EDzpdzt72Drg5Sef+VceDQdfqv6ZGKapWIInRyM7PnYrcd1iBxpV g9q7g9X0n1SHbxLX4EXWf0rH/UedFMmnKdyNr0qAFnHvQ3fHINrT8COi1s5yaSOKY093 iF+yaXc3f2hnwzwCNYqlSQa+c65wfWdvgvmB3uLCXK8CcImptH9VtPsOpKJEsQx4d6Mr Iz3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786538549; x=1787143349; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xJ9VAtOW4dvyLTFJEa/GHt4ssfJ12G8OyYzymmqsAo4=; b=pb370y3kbPqQb7qmtCydV4WIF2KjQXbHBkcyc4ZTcMkxutvl97nx4bUakICF8dN/WL NCvNFG94+B53MScnIkXKtBWjUtIeM3lSzZAcT8SjZEgg0QYUKWxujSChLlwJmeXq16c1 zJEjUEZQoBm/e/+hy+DqtIl1kyvkBXMjJpfPX8JJZEtQAk0dqj3SAsyC/17/+xixY8XQ yi7a2r9CnJy1GoLaxcxJ23k3aUakzw9WFMzNPYIei5aEvCOOwMIf6Q4YvOX3sesEjyvc JB60tw5fO1uXjLzFTktTSZH0T4yquq8Kegcfm1PY/Mh/NS8fngDdOSX8lJlIKxgI+C9T 3VYg== X-Forwarded-Encrypted: i=1; AHgh+RqQ/IvG/OpmKRm2q59PMHfBbUM4qw4pmDjCVhJXqbWskSv1wAWyJz7eao/qR8gcbhJba7JcCc9Bkx+hUwk=@vger.kernel.org X-Gm-Message-State: AOJu0YyyouwQbHFAsY+VYP6iL9cyis3P7zQ8cjCjEv9KrY/rTToBb/ps +KWWD1n+slQkNrcsDWmrebKgZRwXslRAVAUAwlDiNPqgpogfrcMCcAsJrQWXpq9sCDXk0JTRn11 INU7x9guvAH2nrgb6Io1oZyQIjS7q1W3OFb44lN4IXK3RPjOaFaR4kRR8jWVUPOWRODtlWbXpqH Q= X-Gm-Gg: AR+sD11/A+VV64jEanCNhAGxP/JVtFNSaJ+WawiBr+/M9TjAzT4bFElIjvcZQjLBI3n jqGZpQFjC0JZoDAahlxPAIjVe9nQhRtK3mMmaMyj+8YkLMkTeYIcI1mss6qR2gyTA46+YrpEYuT 59OihqM+OcfeHW9cn7a9eqFbkdJ8uGnaz8yHWQ+PZ39IRxuRiPhok6+Z83paaPKXxjuCdex2gb9 rf+S90FmL4Bv+lBDzI5j53VWRFeiGLhrCsvAtMM54ECrRQyvfwErP7o20cspcKR1E69KxClKF3M 7hG5QuEZc3GxLGEUnlAQjYdaKl8IsD0KuhJ/0O1k2SzCmYCTvrCzYZtGjZz9u1rpgib+/zIsb/N l+w4vvaFELVz7jJWx4p3d6asEdIW0Y/jIsHu72OfPn5ryUuOtpRG/4PrDuocfYK0mgjs= X-Received: by 2002:a17:90b:4b81:b0:36d:b424:4f17 with SMTP id 98e67ed59e1d1-393011b2a20mr4777178a91.1.1786538549110; Wed, 12 Aug 2026 05:42:29 -0700 (PDT) X-Received: by 2002:a17:90b:4b81:b0:36d:b424:4f17 with SMTP id 98e67ed59e1d1-393011b2a20mr4777039a91.1.1786538548133; Wed, 12 Aug 2026 05:42:28 -0700 (PDT) Received: from [192.168.1.6] ([122.177.240.91]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f94adf39sm3478809a91.11.2026.08.12.05.42.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 05:42:27 -0700 (PDT) Message-ID: Date: Wed, 12 Aug 2026 18:12:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur: Add missing USB clock, power and bandwidth votes To: Abel Vesa , Greg Ociepka Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Wesley Cheng References: <20260812083522.774711-1-greg@ferrisoft.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwMyBTYWx0ZWRfX3ZwoxT/amE/Z QquJwi6/PODz9DERvsi75BA3dr/8/Qe/S6A5a265mQlalFUUoenWKFbjqnK756Fb04lwnpP/rhs GTnS8ytVE7H2cPQF+v42SIQ5uEHm+ok= X-Proofpoint-GUID: IRSV45LMTvh51p37hB7BS6Kkxc1ST_A7 X-Authority-Analysis: v=2.4 cv=fpDsol4f c=1 sm=1 tr=0 ts=6a7c6a36 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=8gVGPzDiWuseyeRcxd+aqA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=a8UEx8NLAAAA:8 a=EUspDBNiAAAA:8 a=WuHgnROwf8Ibkt1w3KoA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=-yeuc7zBjbfZT8aiaP-D:22 X-Proofpoint-ORIG-GUID: IRSV45LMTvh51p37hB7BS6Kkxc1ST_A7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwMyBTYWx0ZWRfXyukh7No5YRg7 6qcD2bnixZqZhjRxL+wY3tBUnN9UUqml1plRpRoaRN3BhW/S2Bc8BFzE4hTrgt+oF3oyfjP6JRc dYRH5e8dfVYLUArvgXzGJKp4l9Q6ws5us6Wc2i/xdk7qzu6gQVQWSP/EgWn5G7jJqbQHP32PRyK i8rwJvsP+hZK9egBosfp3dgURIwJnDbc45cTqgu1ktrGfp4HRmSDgOj1O2Xf2tY1jT+QOAgxDQU 6sX1PlDDjw+0KDQyRnwPVo2d3f9nU8+kAdPU0v1gxAULfZubonGexgf773uhrwOnQl+nSvqHw3F 2Q91tXc+J0pOqkoX/ALiDWYEDudwUPxXn6L3MFd/tMluw7p4Ukwg+mAOXCzJNWF3XJc1o5wIIFT lTl0s3Yqo9REiHXTFjps7I5KG5WDFp3rVdXV3a9MSB6gU+GKcBrwPb8xq746yxDhUNh96fx/FEg XBUIEyfG6GA27bRhMBw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120103 On 8/12/2026 3:53 PM, Abel Vesa wrote: > On 26-08-12 10:35:22, Greg Ociepka wrote: >> The four USB3 controller nodes on Glymur (usb_0, usb_1, usb_2, usb_mp) >> are missing three property groups that Glymur's own usb_hs node at >> a200000 already carries, and that Hamoa (x1e80100) carries on all five >> of its USB controllers: >> >> - assigned-clocks / assigned-clock-rates >> - required-opps >> - interconnects / interconnect-names >> >> Without required-opps the controllers place no performance state vote >> on their power domain. Measured on an Asus Zenbook A16 (UX3607OA) with >> a SuperSpeed device enumerated, CX aggregates to SVS while the >> controllers run their master clock at 200 MHz: >> >> $ grep -E "^cx " /sys/kernel/debug/pm_genpd/pm_genpd_summary >> cx on 128 >> >> $ grep "usb30.*master_clk " /sys/kernel/debug/clk/clk_summary >> gcc_usb30_sec_master_clk ... 200000000 >> gcc_usb30_prim_master_clk ... 200000000 >> gcc_usb30_mp_master_clk ... 200000000 >> >> 128 is RPMH_REGULATOR_LEVEL_SVS; rpmhpd_opp_nom is 256. With this >> patch applied the same measurement reads 256 while a controller is >> active. >> >> Without interconnects, dwc3_qcom_interconnect_init() silently does >> nothing: of_icc_get() returns NULL rather than an error pointer for a >> device without the property, so probe succeeds and icc_set_bw() on a >> NULL path is a no-op. No USB-DDR bandwidth is ever requested. >> >> Without assigned-clock-rates nothing programs the master clock RCG, >> which keeps whatever the bootloader left behind. On this machine that >> happens to be the correct 200 MHz, but ftbl_gcc_usb30_mp_master_clk_src >> also allows 66.67 and 133.33 MHz, neither of which sustains SuperSpeed. >> >> Add all three groups to the four nodes, mirroring usb_hs. The >> interconnect paths follow the provider layout in >> drivers/interconnect/qcom/glymur.c: usb_0/usb_1 sit on aggre4_noc, >> usb_mp on aggre3_noc and usb_2 on aggre2_noc. >> >> Fixes: 4eee57dd4df9 ("arm64: dts: qcom: glymur: Add USB related nodes") >> Assisted-by: Claude:fable-5 >> Signed-off-by: Greg Ociepka > > This looks OK to me. > > Reviewed-by: Abel Vesa > >> --- >> Note for reviewers: Hamoa additionally marks all five USB controllers >> dma-coherent, while Glymur marks no peripheral DMA master as coherent >> (only the SMMUs, PCIe controllers and remoteprocs). That difference is >> deliberately not touched here since getting it wrong is a silent >> data-corruption class of bug, but it looks like part of the same >> omission. Is USB DMA coherent on Glymur? > > I think so, but lets see what Wesley thinks. > It is dma-coherent. Regards, Krishna,