From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD3D318EE3 for ; Tue, 13 Jan 2026 15:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768317602; cv=none; b=grWFRKcdd6LKEP2ABhOAWpwcJFfDfOd5gpx0zc12A2P/8eFF8VdB9EfY5O6JEOZueDbP90mya45ZcqG/btOq9jJkVS8iqe32HcouFjUj9hNuahrJzvBSNGsGVfQc7guDe/bPyGUDlIjsAid1xnapY0raF/5UcTYqlcHSI5LwbTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768317602; c=relaxed/simple; bh=u9QDlVi5vshsl+vRhqqYxfjpSezB/lW7iF66MEmIA8U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uN9wLpgIVRqH+mvG0utj9E9ZWfQkCx07bspJfVOS6ValXI60NHcKn3+2oq4EYhw5sFdI576F6i9DAay+CfTfF5+HWoaNSklHR6f5ops22b0qwSAVgYaPYYZOiqbLUD32fdWaW9wsCk53fzeAAliEx0eqAKvmp+QyupgBZWiu4D8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LMVbzxrg; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LMVbzxrg" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-45a81568eafso1583663b6e.0 for ; Tue, 13 Jan 2026 07:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1768317600; x=1768922400; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jyu7NzFFuKWq53tGsr5pg2vni176XxXnsvICQ50qCzI=; b=LMVbzxrg4bWkZAy1sHPi1J3Aik5C4kGVfzwnuZ8nnWcB7fj/o8NPgzXilzpt1J7a0Q /IUFwWlBvHKVBkwSq3inO1jixUIQFHLfnFceJy/KavsB/8ZVeHSn0Cjn9zHMM7G5v0sM Ti14b8LRUQVKPro5VkXSwnfMwNCq7sHcX0Ed2lQKNHlmmGwCOQ/yMcxeIXmKnThWZryD Hixb5uxf8goggI/n61ioai3GEnNMORtrmavhUB7xQ1LC4kCi5oxakkUMXJOAzj3Gcx07 Bq2Ictovo+PLUAjIKYUe480oNWpfCAfX+JPwLIroPkQi01SCnjHErsVTfSH4dhDaYcvC 1f6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768317600; x=1768922400; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jyu7NzFFuKWq53tGsr5pg2vni176XxXnsvICQ50qCzI=; b=wkCWwkyrd6D7Hh40qZGNezKDhBBZQq+F3kmw1YZrawW392Q53snXdNp2xuD20iCho3 +QnQ1UDoGg24D2keCeHmg9jYC6QACahq9rk6V2MFQGSEMV9HdHTUdfmbt2y7VQRDOYN2 OSwjzipIKHJjhAiMNB7aL4x/L9KFUSdIUv5c4hfldf4AIoiAS+pPX+pXxjLiVjYYSqKC atv/7vgV1UgBXzvbZYkU7TvvNTGxQF9G5pkUEX5tmoP7hT9c0KzJN1xWueFJkMxNG4zL 5zraTWpUtcr2itEa4h0IPK8q7S1vB4oXZffthESUgWZCoVqjPfv7mwApVKQqxMdkiLWA l/vw== X-Forwarded-Encrypted: i=1; AJvYcCWoaVDymTxIaD2XbmTshs13+4S7A0vM5e1L2YDnzx6MWqxY/Y7hx9FgZpxQawgHfvk6fk8pWZp5D4gRkjM=@vger.kernel.org X-Gm-Message-State: AOJu0YzewnSzay6TY844Tb9/4MJrAw6bvv5HnsWjOiBUS6Bx7Es8ovw2 yzD6m898JO9VTX9gKQBe+Mf3IU5JhRK4BAPbK4WlghdRf4aBEKA7wMNNzncfmnsPtlo= X-Gm-Gg: AY/fxX7hnxpvVoYDwJeNjyO9Heo/zQ+aEAwGFaOZhVBGVpqmykjdLpXQwMlTrw07XXn Eo2lOaSa36LBUnZv3KHWpJJx2PMiP4RlLoSFHKvk3fOwQ6eMr3XTmoveXLGdaaMTYrlHQHEGlBH QKU1ZHmOFWXjM4OYuFuqDWLV6rwipEWdIhOKXFtmt2Y2n5zztSQ7/F0afJOsVMsrjULGPqkWAQe NMIlQnHNrpmszwWZ5U9lR+Oz36A8dZwLlv2+Mz/DyJzHvhe86lGYq+DR/6iZjrZ8NjbxU0V+Lp3 g1G4I5NaiVTE5DiMBtcpEXQT+74Cx5ypVRqBT3g7qOLEAlt1FJWTjsUBtMWyPv2UOHjUVaBn/JR te07eHPhAG7PhTLCYz+TEWBjy7IMqbQPZyhXkXH5Q0DycbrEOsMSw2iMsYOVhrAeECJPryTitlt iWRSNBuGugR+OTCBB7/Osa6a9NTGA4y5MNcsKm0Mlvog9SZ2+ifPs1FiR9u99T X-Google-Smtp-Source: AGHT+IF1pGQlTvSNUkaOR8+ke2GdpdxW5UboFnSiwOvVZ/7w1O4JoRpMuIbNcLLEOUliN4nj8DK/Fw== X-Received: by 2002:a05:6808:4a58:10b0:459:b48b:c731 with SMTP id 5614622812f47-45a6bccccdfmr8266556b6e.2.1768317599608; Tue, 13 Jan 2026 07:19:59 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:2f58:e1e3:bd08:f09e? ([2600:8803:e7e4:500:2f58:e1e3:bd08:f09e]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3ffa50e1e29sm14572053fac.19.2026.01.13.07.19.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 07:19:58 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 09:19:57 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] iio: adc: ad9467: check for backend capabilities To: Tomas Melin , Michael Hennerich , Nuno Sa , Lars-Peter Clausen , Jonathan Cameron , Andy Shevchenko , Olivier Moysan Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260113-b4-ad9467-optional-backend-v2-0-0a27e7e72f41@vaisala.com> <20260113-b4-ad9467-optional-backend-v2-3-0a27e7e72f41@vaisala.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260113-b4-ad9467-optional-backend-v2-3-0a27e7e72f41@vaisala.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/13/26 6:12 AM, Tomas Melin wrote: > For cases when the backend does not support test patterns or calibration, > do not attempt to use those features. > > Signed-off-by: Tomas Melin > --- > drivers/iio/adc/ad9467.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c > index 9cfe66425d4e91e215cccc40e24a92c5e99e9b87..ce7dde8b79540bb0eabfba9470b3984e8723d4b7 100644 > --- a/drivers/iio/adc/ad9467.c > +++ b/drivers/iio/adc/ad9467.c > @@ -645,6 +645,9 @@ static int ad9467_backend_testmode_on(struct ad9467_state *st, > }; > int ret; > > + if (!iio_backend_caps(st->back, IIO_BACKEND_CAP_TEST_PATTERNS)) > + return 0; > + > ret = iio_backend_data_format_set(st->back, chan, &data); > if (ret) > return ret; > @@ -665,6 +668,9 @@ static int ad9467_backend_testmode_off(struct ad9467_state *st, > }; > int ret; > > + if (!iio_backend_caps(st->back, IIO_BACKEND_CAP_TEST_PATTERNS)) > + return 0; > + > ret = iio_backend_chan_disable(st->back, chan); > if (ret) > return ret; > @@ -807,6 +813,9 @@ static int ad9467_calibrate(struct ad9467_state *st) > bool invert = false, stat; > int ret; > > + if (!iio_backend_caps(st->back, IIO_BACKEND_CAP_CALIBRATION)) > + return 0; > + > /* all points invalid */ > bitmap_fill(st->calib_map, st->calib_map_size); > > Same comments from my review of patch 2 apply here.