From: Michael Walle <michael@walle.cc>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Vladimir Oltean <olteanv@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
alexandru.marginean@nxp.com, claudiu.manoil@nxp.com,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 devicetree 0/6] DT bindings for Felix DSA switch on LS1028A
Date: Mon, 24 Feb 2020 12:38:26 +0100 [thread overview]
Message-ID: <f92f01d60589d94bb25a38dd828200b0@walle.cc> (raw)
In-Reply-To: <20200224112026.GF27688@dragon>
Hi Shawn,
Am 2020-02-24 12:20, schrieb Shawn Guo:
> On Sun, Feb 23, 2020 at 10:47:10PM +0200, Vladimir Oltean wrote:
>> This series officializes the device tree bindings for the embedded
>> Ethernet switch on NXP LS1028A (and for the reference design board).
>> The driver has been in the tree since v5.4-rc6.
>>
>> It also performs some DT binding changes and minor cleanup, as per
>> feedback received in v1 and v2:
>>
>> - I've changed the DT bindings for the internal ports from "gmii" to
>> "internal". This means changing the ENETC phy-mode as well, for
>> uniformity. So I would like the entire series to be merged through a
>> single tree, probably the devicetree one - something which David
>> Miller has aggreed to, here [0].
>> - Disabled all Ethernet ports in the LS1028A DTSI by default, which
>> means not only the newly introduced switch ports, but also RGMII
>> standalone port 1.
>>
>> [0]: https://lkml.org/lkml/2020/2/19/973
>>
>> Claudiu Manoil (2):
>> arm64: dts: fsl: ls1028a: add node for Felix switch
>> arm64: dts: fsl: ls1028a: enable switch PHYs on RDB
>>
>> Vladimir Oltean (4):
>> arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for
>> ENETC
>> RCIE
>> arm64: dts: fsl: ls1028a: disable all enetc ports by default
>
> I applied these 4 DTS patches with changing prefix to 'arm64: dts:
> ls1028a: '.
Oh, then the kontron-sl28 boards won't have ethernet because the nodes
are
disabled now. I'll send a patch shortly which explicitly sets the status
to
"okay", hopefully you can pick it up so it'll end up in the same pull
request
as this one:
arm64: dts: fsl: ls1028a: disable all enetc ports by default
-michael
>
> Shawn
>
>> net: dsa: felix: Use PHY_INTERFACE_MODE_INTERNAL instead of GMII
>> dt-bindings: net: dsa: ocelot: document the vsc9959 core
>>
>> .../devicetree/bindings/net/dsa/ocelot.txt | 116
>> ++++++++++++++++++
>> .../boot/dts/freescale/fsl-ls1028a-qds.dts | 1 +
>> .../boot/dts/freescale/fsl-ls1028a-rdb.dts | 61 ++++++++-
>> .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 89 +++++++++++++-
>> drivers/net/dsa/ocelot/felix.c | 3 +-
>> drivers/net/dsa/ocelot/felix_vsc9959.c | 3 +-
>> 6 files changed, 265 insertions(+), 8 deletions(-)
>> create mode 100644
>> Documentation/devicetree/bindings/net/dsa/ocelot.txt
>>
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2020-02-24 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 20:47 Vladimir Oltean
2020-02-23 20:47 ` [PATCH v3 devicetree 1/6] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE Vladimir Oltean
2020-02-23 20:47 ` [PATCH v3 devicetree 2/6] arm64: dts: fsl: ls1028a: disable all enetc ports by default Vladimir Oltean
2020-02-23 20:47 ` [PATCH v3 devicetree 3/6] net: dsa: felix: Use PHY_INTERFACE_MODE_INTERNAL instead of GMII Vladimir Oltean
2020-02-23 20:47 ` [PATCH v3 devicetree 4/6] dt-bindings: net: dsa: ocelot: document the vsc9959 core Vladimir Oltean
2020-02-23 20:47 ` [PATCH v3 devicetree 5/6] arm64: dts: fsl: ls1028a: add node for Felix switch Vladimir Oltean
2020-02-23 20:47 ` [PATCH v3 devicetree 6/6] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB Vladimir Oltean
2020-02-24 11:20 ` [PATCH v3 devicetree 0/6] DT bindings for Felix DSA switch on LS1028A Shawn Guo
2020-02-24 11:38 ` Michael Walle [this message]
2020-02-24 11:52 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92f01d60589d94bb25a38dd828200b0@walle.cc \
--to=michael@walle.cc \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®