From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<mingo@redhat.com>, <bp@alien8.de>, <hpa@zytor.com>,
<luto@kernel.org>
Subject: Re: [PATCH] x86/irq/64: fix the missing update on comment
Date: Mon, 22 Jul 2019 17:13:26 +0800 [thread overview]
Message-ID: <f9333bd0-2a62-7380-8172-facee7a61e11@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1907221051580.1782@nanos.tec.linutronix.de>
On 7/22/19 4:53 PM, Thomas Gleixner wrote:
> Cao,
>
> On Fri, 19 Jul 2019, Cao jin wrote:
>
>> Commit e6401c130931 ("x86/irq/64: Split the IRQ stack into its own pages")
>> missed to update one piece of comment as it did to its peer in Xen, which
>> will confuse people who still need to read comment.
>>
>> A bonus fix to identation in ZO's linker script: spaces -> tab.
>
> Please don't add 'bonus' changes. A patch which fixes a stale comment has
> nothing to do with a indentation change in an unrelated file.
>
Kept that in mind. Sorry for the inconvenience.
--
Sincerely,
Cao jin
next prev parent reply other threads:[~2019-07-22 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 8:16 Cao jin
2019-07-22 8:53 ` Thomas Gleixner
2019-07-22 9:13 ` Cao jin [this message]
2019-07-22 8:58 ` [tip:x86/urgent] x86/irq/64: Update stale comment tip-bot for Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9333bd0-2a62-7380-8172-facee7a61e11@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®