From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Keith Packard <keithpac@amazon.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Heiko Carstens <hca@linux.ibm.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/7] arm64: add CPU field to struct thread_info
Date: Thu, 30 Sep 2021 15:23:10 +0200 [thread overview]
Message-ID: <f9362e71-0a2a-ffa8-b428-d52fed7b5228@csgroup.eu> (raw)
In-Reply-To: <CAMj1kXFuzDSxbE7OTV0Sb5UYaGQ5v_yFeq8LYE--kZ_AffaB4g@mail.gmail.com>
Le 30/09/2021 à 15:20, Ard Biesheuvel a écrit :
> On Thu, 30 Sept 2021 at 15:15, Christophe Leroy
> <christophe.leroy@csgroup.eu> wrote:
>>
>>
>>
>> Le 30/09/2021 à 15:07, Ard Biesheuvel a écrit :
>>> On Thu, 30 Sept 2021 at 15:06, Christophe Leroy
>>> <christophe.leroy@csgroup.eu> wrote:
>>>>
>>>>
>>>>
>>>> Le 30/09/2021 à 14:58, Ard Biesheuvel a écrit :
>>>>> The CPU field will be moved back into thread_info even when
>>>>> THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of
>>>>> struct thread_info.
>>>>>
>>>>> Note that arm64 always has CONFIG_SMP=y so there is no point in guarding
>>>>> the CPU field with an #ifdef.
>>>>>
>>>>> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>>>>> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>>>>> Acked-by: Mark Rutland <mark.rutland@arm.com>
>>>>> ---
>>>>> arch/arm64/include/asm/thread_info.h | 1 +
>>>>> arch/arm64/kernel/asm-offsets.c | 1 +
>>>>> 2 files changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/include/asm/thread_info.h b/arch/arm64/include/asm/thread_info.h
>>>>> index 6623c99f0984..c02bc8c183c3 100644
>>>>> --- a/arch/arm64/include/asm/thread_info.h
>>>>> +++ b/arch/arm64/include/asm/thread_info.h
>>>>> @@ -42,6 +42,7 @@ struct thread_info {
>>>>> void *scs_base;
>>>>> void *scs_sp;
>>>>> #endif
>>>>> + u32 cpu;
>>>>> };
>>>>>
>>>>> #define thread_saved_pc(tsk) \
>>>>> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
>>>>> index 551427ae8cc5..cee9f3e9f906 100644
>>>>> --- a/arch/arm64/kernel/asm-offsets.c
>>>>> +++ b/arch/arm64/kernel/asm-offsets.c
>>>>> @@ -29,6 +29,7 @@ int main(void)
>>>>> DEFINE(TSK_ACTIVE_MM, offsetof(struct task_struct, active_mm));
>>>>> DEFINE(TSK_CPU, offsetof(struct task_struct, cpu));
>>>>> BLANK();
>>>>> + DEFINE(TSK_TI_CPU, offsetof(struct task_struct, thread_info.cpu));
>>>>
>>>> Why adding that now ? For powerpc you do the switch in 5.
>>>>
>>>
>>>
>>> Why not?
>>
>> Maybe to remain consistent between archs ?
>>
>
> Does it matter?
Probably not :)
>
>>>
>>>
>>>>> DEFINE(TSK_TI_FLAGS, offsetof(struct task_struct, thread_info.flags));
>>>>> DEFINE(TSK_TI_PREEMPT, offsetof(struct task_struct, thread_info.preempt_count));
>>>>> #ifdef CONFIG_ARM64_SW_TTBR0_PAN
>>>>>
next prev parent reply other threads:[~2021-09-30 13:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 12:58 [PATCH v2 0/7] Move task_struct::cpu back into thread_info Ard Biesheuvel
2021-09-30 12:58 ` [PATCH v2 1/7] arm64: add CPU field to struct thread_info Ard Biesheuvel
2021-09-30 13:06 ` Christophe Leroy
2021-09-30 13:07 ` Ard Biesheuvel
2021-09-30 13:15 ` Christophe Leroy
2021-09-30 13:20 ` Ard Biesheuvel
2021-09-30 13:23 ` Christophe Leroy [this message]
2021-09-30 12:58 ` [PATCH v2 2/7] x86: " Ard Biesheuvel
2021-09-30 12:58 ` [PATCH v2 3/7] s390: " Ard Biesheuvel
2021-09-30 13:02 ` Heiko Carstens
2021-09-30 12:58 ` [PATCH v2 4/7] powerpc: " Ard Biesheuvel
2021-09-30 12:58 ` [PATCH v2 5/7] sched: move CPU field back into thread_info if THREAD_INFO_IN_TASK=y Ard Biesheuvel
2021-09-30 13:08 ` Christophe Leroy
2021-09-30 13:12 ` Ard Biesheuvel
2021-09-30 13:22 ` Christophe Leroy
2021-09-30 13:35 ` Christophe Leroy
2021-09-30 12:58 ` [PATCH v2 6/7] powerpc: smp: remove hack to obtain offset of task_struct::cpu Ard Biesheuvel
2021-09-30 12:58 ` [PATCH v2 7/7] riscv: rely on core code to keep thread_info::cpu updated Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9362e71-0a2a-ffa8-b428-d52fed7b5228@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=hca@linux.ibm.com \
--cc=keithpac@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mpe@ellerman.id.au \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®