mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stian Halseth <stian@itx.no>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Thomas Gleixner <tglx@kernel.org>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	 regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched/cputime: Don't account idle time twice after dyntick-idle
Date: Tue, 06 Oct 2026 13:19:58 +0200	[thread overview]
Message-ID: <f9449162aaea3b43154c3981c50d9bd40340c2c0.camel@itx.no> (raw)
In-Reply-To: <asTWpV1xFQ4opyB7@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Tue, 2026-10-06 at 13:08 +0200, Frederic Weisbecker wrote:

> > Only with steal time, and that is older than the rework. I ran the
> > same
> > guest test on v7.1 and on ad5a9e14ec8b, the parent of
> > cf6444c3e1bb7.
> > Total CPU time per wall second on the loaded vCPU:
> > 
> >                           v7.1    ad5a9e14ec8b   v2
> >   3.7 ms sleeps           0.995   0.996          0.998
> >   pipe ping-pong          0.997   0.996          1.000
> >   steal, sleep + spin     1.029   1.028          1.008
> >   steal, pipe ping-pong   1.338   1.341          1.001
> > 
> > Without steal time nothing was counted twice before the rework.
> > With
> > steal time, v7.1 counted steal time during idle as both idle and
> > steal
> > time. The rework fixed most of that, and what is left with a busy
> > spin
> > after each wakeup is smaller than before.
> 
> Ok and you haven't observed a real difference between your v1 and v2,
> right?
> 
No, not in normal operation. 

It only made a difference with a test-only change that stops the tick
on every idle entry. There v2 added to a pending overlap about 900
times a second, which v1 lost.

/Stian


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-10-06 11:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 19:40 Stian Halseth
2026-10-06 10:11 ` Frederic Weisbecker
2026-10-06 10:50   ` Stian Halseth
2026-10-06 11:08     ` Frederic Weisbecker
2026-10-06 11:19       ` Stian Halseth [this message]
2026-10-06 11:38         ` Stian Halseth
2026-10-07 11:38 ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9449162aaea3b43154c3981c50d9bd40340c2c0.camel@itx.no \
    --to=stian@itx.no \
    --cc=anna-maria@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=regressions@lists.linux.dev \
    --cc=sshegde@linux.ibm.com \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®