From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB9334A785 for ; Fri, 23 Jan 2026 06:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769149736; cv=none; b=M2Jaw8ht5T0TPEjulu5pdYGwGADRGBCrBLaOLQp/bO1NoW/KPPhOFN6JNXyOMGyJi3lKlSspwhtht1qYCWpC89IUsKJJEydUFJpD9FOYqAB/eywNBgirSHV9ixrHopZSK8Hxnul33NdD5Q87BtbftxW9JegOGlPkm46cB+ziDmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769149736; c=relaxed/simple; bh=3jT9NZUzEXDkXmWjrnYYCDqk40FJEePHa/GTVTCRXgM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MN6s8Jga0YenOVv8UYj41Baf1PpSoY2P+P606urlglH57QVai8PyR7n+ELVFcO3wBbWhNYM8by9RTIvgWb34svadO0jiLmmJ9JjsPyD+xVWrNpleIfN/5H3f5/9VCgNdk6Enu1sG9BA3pMo4IQu5o0EKbwwedjhfM0/QSI+zbHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=szwwqKJf; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="szwwqKJf" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-42fb2314f52so1082063f8f.0 for ; Thu, 22 Jan 2026 22:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769149724; x=1769754524; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=3jT9NZUzEXDkXmWjrnYYCDqk40FJEePHa/GTVTCRXgM=; b=szwwqKJfB7EADU3P1N6Ix7rJz7KBp8Djq7U6rWZQv42tCQTJrQFjKTJL/m+JwtJ3sn HL4j3SQK4lA+arJTFEU/Vu4av5EJQ7YSWhDoLhcCT5w/s63GzAyxHy9NbkBZQoQos0wb dldkQ7FdGgSHpJrC92j2pIp/A36HpLmj8X2MIfMlGU2y9f0ZcrSurj2QtSR61Ao7yoy0 QklVMRR0zLHCvodLHDpKdCFD3Y4RD4fdDsvsqVcZvPh8Ip1Yz+eXoTaitYJfi80XJA2/ ec+lreNqxvalC8VRPVTFXEP74n9L2Txy4pKvH0/L73fJWVjHTho0NUpJQRFkG+Y1W9J8 hj9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769149724; x=1769754524; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3jT9NZUzEXDkXmWjrnYYCDqk40FJEePHa/GTVTCRXgM=; b=oGkGaotfL9Z0wx2KJh/lpBAfM7XZzc3/zK+o7cT899GpRvtXDOrXPE5aIfR3Nna8io 35tkfGFqerbf5j5mBs45lj9ZvAsyuJq8RVsAoOif7yuv8/TfCOAKbJH/r9DHdvCSteUO IEh9d/R68p9zQxy7cBjiqiO7yebGo7XbMvchvYN8kGObExn7dH9N8e6J9GjTyDkbIvzF ANA6oFAgRwDYSQqATwDLmTZUX2+0gBKMalxUFIjFsTCxnnVD2j5usujZFFWnheiPUP7f l8+MYtdYDnWNANHA3dyjW2SOPLIYNM8LXde9abUBki+R29tz1Ug28QUUKAORdl7qytFd nORA== X-Forwarded-Encrypted: i=1; AJvYcCXzt4wflIs6fwJZG11ZqNLrxLpRn+njUDXFCGr8X1HCyoQ9geshRTebb7Ntl80m61cUwPdCJbpdFhysjzo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx/LsmFhJRrVqs4ijK/fUquUbazjwG3Eb6wKhBYpjEXpary2eU V5OD4bO88oSAyw/e5x08BqLGN7wtdCOxvFZKZjYJvPtgj/rL+AkePezgpwnv7TuNt84= X-Gm-Gg: AZuq6aIDBB73gZ95VmwvL8/QP2wIuVATuWObN/gGlo+VauPeuLPnJ/3r9Fht2YnkxTU NOCyWmmMK9HUjLXrzaSbQ+Vp4l99vlQveMv088e1mSB+yYKrIH7XGFDjavnGf802m5OaCnXLuyB R96Tpah4XdUjqr2Qz0OBtDhiARwxbI9tERIbZBgclKqo0sqdm8JvaNaCiO8nEd9/k4X6ZjiexCg ZU5xkieMBjaXceeK0e1K0LFUK6KFnYmMcIBdi/LJ4+Hd1eA7CQwlv6Agu2IIkX8kq9P2nB+MZ+u 3XjT7EWVVCU1SI+ukwgOuzKpyJjgciqyvVSYA40wD+51PAIgBh7SdA1eJPny8qPc/eH3RDO+wzk QBtMQcMDmIv5f9ohytHHoovjTkGx0vJTUaAt4dgbHTzB0ryzExGXzMVbpSgYhJl9wW7LV3fHANJ 8GNqWuLCAPDC4Kg2ZbSg== X-Received: by 2002:a05:6000:2c08:b0:435:9522:2bc9 with SMTP id ffacd0b85a97d-435b15bd97fmr3431523f8f.5.1769149723683; Thu, 22 Jan 2026 22:28:43 -0800 (PST) Received: from draszik.lan ([212.129.79.190]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1f74b15sm4214449f8f.35.2026.01.22.22.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 22:28:43 -0800 (PST) Message-ID: Subject: Re: [PATCH next] phy: google: fix build dependency for Google Tensor USB PHY From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Roy Luo Cc: Vinod Koul , Neil Armstrong , Peter Griffin , Tudor Ambarus , Joy Chakraborty , Naveen Kumar , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel test robot Date: Fri, 23 Jan 2026 06:28:44 +0000 In-Reply-To: References: <20260121-next-v1-1-c18068b091b9@google.com> <7c78f9da40022e7bbf850ae8989c617bdc30cc95.camel@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Roy, On Thu, 2026-01-22 at 11:00 -0800, Roy Luo wrote: > On Thu, Jan 22, 2026 at 2:39=E2=80=AFAM Andr=C3=A9 Draszik wrote: > >=20 > > Hi Roy, > >=20 > > On Wed, 2026-01-21 at 22:21 +0000, Roy Luo wrote: > > > The Google Tensor USB PHY driver uses the Type-C switch framework to > > > handle orientation changes. However, the Kconfig did not specify a > > > dependency on the TYPEC framework, leading to undefined reference > > > errors when building for architectures or configurations where > > > CONFIG_TYPEC is disabled or configured as a module. > > >=20 > > > Add 'depends on TYPEC' to the PHY_GOOGLE_USB entry to ensure all > > > required symbols are available during linking. > > >=20 > > > Fixes: cbce66669c82 ("phy: Add Google Tensor SoC USB PHY driver") > > > Reported-by: kernel test robot > > > Closes: https://lore.kernel.org/oe-kbuild-all/202601210825.ELrpQeED-l= kp@intel.com/ > > > Signed-off-by: Roy Luo > > > --- > > > =C2=A0drivers/phy/Kconfig | 1 + > > > =C2=A01 file changed, 1 insertion(+) > > >=20 > > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > > index 142e7b0ef2efb9209781800ee47b820a91b115ae..5531ff31d8156cb164c32= e3e52d4a57b26a62d8d 100644 > > > --- a/drivers/phy/Kconfig > > > +++ b/drivers/phy/Kconfig > > > @@ -49,6 +49,7 @@ config GENERIC_PHY_MIPI_DPHY > > >=20 > > > =C2=A0config PHY_GOOGLE_USB > > > =C2=A0 tristate "Google Tensor SoC USB PHY driver" > > > + depends on TYPEC > >=20 > > Can you make this > >=20 > > depends on TYPEC || COMPILE_TEST > >=20 > > to allow some better test coverage? > >=20 > > Cheers, > > Andre >=20 > Hi Andre, >=20 > Whether to add COMPILE_TEST for build coverage was discussed in > another thread [1]. My takeaway from that discussion is that > COMPILE_TEST is intended to substitute for ARCH_XXX in build > testing and should not be used without it. Once ARCH_GOOGLE is > present, we can add "depends on (ARCH_GOOGLE || COMPILTE_TEST)". COMPILE_TEST is not limited to ARCH_xxx. It allows drivers to be compile tested even if the current build doesn't enable whatever option (like TYPEC). See also https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.htm= l#compile-testing Cheers, Andre' >=20 > [1] https://lore.kernel.org/all/CA+zupgwgfKwPYqj8G2tNf4pEXNEWA+vL2WYJPhJ1= 6xExgko7Dw@mail.gmail.com/ >=20 > Regards, > Roy