From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40ACC07E99 for ; Tue, 6 Jul 2021 02:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C88426197F for ; Tue, 6 Jul 2021 02:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbhGFCbS (ORCPT ); Mon, 5 Jul 2021 22:31:18 -0400 Received: from mga11.intel.com ([192.55.52.93]:12947 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbhGFCbQ (ORCPT ); Mon, 5 Jul 2021 22:31:16 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="206035224" X-IronPort-AV: E=Sophos;i="5.83,327,1616482800"; d="scan'208";a="206035224" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2021 19:27:58 -0700 X-IronPort-AV: E=Sophos;i="5.83,327,1616482800"; d="scan'208";a="456898986" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.4.147]) ([10.238.4.147]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2021 19:27:55 -0700 Subject: Re: [PATCH] perf list: Skip the invalid hybrid pmu To: Andi Kleen , acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com Cc: Linux-kernel@vger.kernel.org, kan.liang@intel.com, yao.jin@intel.com References: <20210610051646.4003-1-yao.jin@linux.intel.com> <77380298-b3d5-d165-c8d4-a24b22d15b0c@linux.intel.com> From: "Jin, Yao" Message-ID: Date: Tue, 6 Jul 2021 10:27:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <77380298-b3d5-d165-c8d4-a24b22d15b0c@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, hi Jiri, On 6/17/2021 12:37 AM, Andi Kleen wrote: > > On 6/9/2021 10:16 PM, Jin Yao wrote: >> On hybrid platform, such as Alderlake, if atom CPUs are offlined, >> the kernel still exports the sysfs path '/sys/devices/cpu_atom/' for >> 'cpu_atom' pmu but the file '/sys/devices/cpu_atom/cpus' is empty, >> which indicates this is an invalid pmu. > > > The patch looks good, but it would probably make sense to fix the kernel to avoid this too. > > Of course the tools patch would still be needed for older kernels. > > -Andi > > Any comments for this patch? Thanks Jin Yao