From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dragan Simic <dsimic@manjaro.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] docs: dt-bindings: Specify ordering for properties within groups
Date: Fri, 7 Mar 2025 13:41:38 +0100 [thread overview]
Message-ID: <f9779027-63cf-4cb7-8399-1f3f1843c900@kernel.org> (raw)
In-Reply-To: <0df01d9863f72df3bebff1868f010954@manjaro.org>
On 07/03/2025 10:50, Dragan Simic wrote:
>>> Applying strict alpha-numerical ordering can result in property lists
>>> that
>>> are suboptimal from the usability standpoint. For the provided
>>> example,
>>> which stems from a real-world DT, [2][3][4] applying strict
>>> alpha-numerical
>>> ordering produces the following undesirable result:
>>
>> BTW, your entire commit msg still has incorrect wrapping. Please use
>> standard editors which understand Git commit msg style (which I believe
>> is equal to Linux submitting patches).
>
> Sorry, but what makes the wrapping wrong? I wrap patch descriptions
> at or well before 78 columns, which I belive is the desired way to do
> so. The longest line in this patch description is 77 characters long,
> which is still below 78 characters.
Because it is not correct. Read submitting patches. Run checkpatch.
>
> Also, please note that I don't "just use" some random editor, but I use
> a highly customized Vim setup, in which I over time wrote about 46 KB
> of Vimscript code in my ~/.vimrc, all by hand. I've even contributed
> smaller patches to Vim.
OK, so not random, but incorrectly configured. Different tools, same result.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-07 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 4:33 Dragan Simic
2025-03-07 9:28 ` Krzysztof Kozlowski
2025-03-07 9:50 ` Dragan Simic
2025-03-07 12:41 ` Krzysztof Kozlowski [this message]
2025-03-07 12:54 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9779027-63cf-4cb7-8399-1f3f1843c900@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®