From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADBEF14A4CC for ; Sun, 8 Mar 2026 01:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772933071; cv=none; b=qyyT9VVnSO1GBzi7gy+yZxB53w6NBtadaor5cfV4hFKKXM93FXClw5p3k/PplQv/d066t5CJ6pU8oqbGgu7b9MlCfzfcP01ixiZkpsQ+dHcHhnC9BPLAImI1wjBzxUPj0REzZ7CJjIE+QlLCoVkdoNDDaWK4gsT/syKrRs4B380= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772933071; c=relaxed/simple; bh=hf/5ZXiEGArucJZbM+PwA7Znqt3CDYwZUxCKA3I3kOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U6k466Jl+CSl+xWawzM+B6Q6B1oAXgQRccbdlYlnFTBEc4ZD34bWZ1QWKECgL6Ad5Q7SzKZDtNAGdzQEphEyc95tevBFSneGxszcQZiDdwjZ9bYoxFYAA7Lc5SxyOSPkkZJ4s4qZTY4OELHAD8VuoFz1hiqxo861gsCmCL4LwBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IJH+MclB; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IJH+MclB" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2b6b0500e06so12750060eec.1 for ; Sat, 07 Mar 2026 17:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772933070; x=1773537870; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=yDbXTCChWzz1yLsYxOAif8TvBjt0J98aJbaBR4LR77E=; b=IJH+MclBj6xEN0cvykgYaa+k9rI8VT7CrK36IGqCpIdselga3JH/SVBO5+eb3BUyVO Ifvq0E+kFk1rcp/PCJ5tlxmrssjj7nvOng9PgQW8zBLCVPpzYNozYc66caEUQBbrC+eZ 1ujEpHbz4rKg2KTUijxYRYdjONzyiJmzbBkZkT9YCWISvzbuYlKIROJAoSquV9ePCBwF k3wT/wXh12GmIqsecMPb7X5KF4TDnn0zSyCY4le7IQ5CQ+WL/lPqny+KrllutcPcEJlz R/SspOHguySh4SfgLMcc5G3BE4KRWmvEy+gLGAaOWChxAmC1hdW4Yp1ggFcDAllw/VHx aeWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772933070; x=1773537870; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yDbXTCChWzz1yLsYxOAif8TvBjt0J98aJbaBR4LR77E=; b=I+V2jZl9oS5i4KPp2aDpg9yKa82YLqzAgIZgg7WjyFcDfpMZSX2Cri86gh/bSpRkbe IopMlTblSuhkA0ZvHA4Lg0iMMA12dsgxxj+/VWFeB2bcq/Sce88JUeR7eccWL/nQsHsi p6RoxeMu/T5cbw6b7+rqoRa8gkLAumVUkjRyMWH7FJoEvdRam9eMX1SmuV6w59MBtncV JEwiy7fjJGR4PHaf1L1Ecj2BTvmrL0VMZtXGlcVeKnCPIQnGUrLgEmLR6inZ7xZKC2NF NXA++hdiWe4HBOLsujJpkcD5SgdLX5yFGqatQ4D40bFv9VmB3YhK/5bY64zRqfuzbh+1 EbPw== X-Forwarded-Encrypted: i=1; AJvYcCVhdWdLrpriwNUOkd8pTgqVoNkCfQDO/A4yTfgeOHUbqYFtZhxdY+PUuCejrVqMDqIgQSyMpPmKO8wru1M=@vger.kernel.org X-Gm-Message-State: AOJu0YztlwHF4gov87y+RoYhPOcRdeTj/RMBwwksvVgfs8nnx01em7gR F3VQ2oCXCl+nEXMYwFLd93bNjPVTjaVf48NVdq1hRP+hR6Ffylp33jCkfR/f4U/y X-Gm-Gg: ATEYQzwKS9AF9EPMPpgotKzYIczrf29TkvxJ73USw9LItLrvgXA6d75QIlsjmTE33HE sMNxcQ36rsHJUky0d8aeshw38+Glo+HpF4DxjUsZuxUio7v7ZAsxir279aa3swV7Ww747SCv3Mf jFuuw428kvxHgcMmzYOokIQ3Gh27vZ2ku/2tyXQR5m4ZiEs6fGDE4t9HiiPJZvZqkzb837T967w 0G9HojCvhNrvFpLKk3CbrodJdRZwvGlbQgxVVs7dzkHLbbjfhNkFSJJqK8MHQt9EYTUK5GVzVkV EIoPlOL+oLVw94aKLGRDE43sJtLgyLwzhHHVSsUGQ4reIOziIyDNwLcrKQgyrC7nGOpbchFThoN 4VrAu9zbzbv8BHd3EIsJXQw82CRjoxFOPX5/+vRmOlI1LARtzMmcLe4iABeeTt8/c8NaqQeGaXw Ili/9A0TEpdO4NlG8dBCEw6baIOL2F0ceoEhsk X-Received: by 2002:a05:693c:2b0a:b0:2b0:48f7:837d with SMTP id 5a478bee46e88-2be4deaed79mr2433262eec.11.1772933069745; Sat, 07 Mar 2026 17:24:29 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be4f82851esm4364890eec.10.2026.03.07.17.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 17:24:29 -0800 (PST) Sender: Guenter Roeck Date: Sat, 7 Mar 2026 17:24:28 -0800 From: Guenter Roeck To: Tabrez Ahmed Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Brigham Campbell Subject: Re: [PATCH v2] hwmon: (ads7871) Fix incorrect error code in voltage_show Message-ID: References: <20260307115226.25757-1-tabreztalks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260307115226.25757-1-tabreztalks@gmail.com> On Sat, Mar 07, 2026 at 05:22:26PM +0530, Tabrez Ahmed wrote: > The voltage_show() function returns -1 when the A/D conversion > fails to complete within the polling loop. -1 maps to -EPERM > (operation not permitted), which does not describe the actual > failure. > > Replace this -1 error code with -ETIMEDOUT to better indicate > the timeout condition to userspace. > > Drop the else block after return. > > Note: not runtime tested due to lack of hardware. > > Signed-off-by: Tabrez Ahmed Applied. Thanks, Guenter