From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752448AbcGAE11 (ORCPT ); Fri, 1 Jul 2016 00:27:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:57095 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbcGAE1Z (ORCPT ); Fri, 1 Jul 2016 00:27:25 -0400 Subject: Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc() To: wangyijing , Coly Li , axboe@fb.com, Kent Overstreet References: <1466561446-30443-1-git-send-email-wangyijing@huawei.com> <5775D0E8.4060201@huawei.com> Cc: Eric Wheeler , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org From: Coly Li Message-ID: Date: Fri, 1 Jul 2016 12:24:46 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <5775D0E8.4060201@huawei.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 16/7/1 上午10:09, wangyijing 写道: > > > 在 2016/6/29 18:20, Coly Li 写道: >> 在 16/6/22 上午10:10, Yijing Wang 写道: >>> Cache_sb is not used in cache_alloc, and we have copied >>> sb info to cache->sb already, remove it. >>> >>> Signed-off-by: Yijing Wang >>> --- >>> drivers/md/bcache/super.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c >>> index f5dbb4e..aecaace 100644 >>> --- a/drivers/md/bcache/super.c >>> +++ b/drivers/md/bcache/super.c >>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj) >>> module_put(THIS_MODULE); >>> } >>> >>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca) >>> +static int cache_alloc(struct cache *ca) >>> { >>> size_t free; >>> struct bucket *b; >>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page, >>> if (blk_queue_discard(bdev_get_queue(ca->bdev))) >>> ca->discard = CACHE_DISCARD(&ca->sb); >>> >>> - ret = cache_alloc(sb, ca); >>> + ret = cache_alloc(ca); >> >> I am not sure whether struct cache_b *sb will be used in future, I >> suggest to let it be for now. >> > > We have copied sb to ca->sb, so if we need sb info in future, we could get info from ca->sb. > Hi Yijing, Your point makes sense, please add Reviewed-by: Coly Li in your patch, if you don't mind :-) Thanks for your interpretation. Coly