From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BB383F0AB6 for ; Tue, 30 Jun 2026 14:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782830805; cv=none; b=qC+kiTT+8qkFyD2rMRCrVlvjXUpCXRTAcv2vD0nrywAepEfrpXJLtfmSE9U3VBrbacc85bINUYFtFTdOJq6C1qX9BijnqN/FRQgWQyd0zzEEuo6/vsCkKFPqLZZmc+aGpTac/YCvfpJ7nUxKgmlcngG9UhpeFWzFeDDVYdfEEqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782830805; c=relaxed/simple; bh=ehcxL5HeeJWAK/5s32YamGLKBqKKC82AhYE7FuOqU+0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AEm96reUk2BFwypW9ycncgQWcySFacZcPgDu4aTwmN2hxPmO+ygzaitn3VMicDL0f9KDW0S8XukFmAYLJAHJopDGbIIQu5yMtgkllj6i7TZ7fCsmjFLFox7piUra+vAaPVFa9mUeUDrOlCwScVeoYBDXaPGTNrZ1qyCsJQsER9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S0wOhgnY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RAgj5rWS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S0wOhgnY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RAgj5rWS" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UEDGfp2216870 for ; Tue, 30 Jun 2026 14:46:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kM6XssLZS5uE8jkI5SWx0ezfn7uyBMeOizbquvZVlhM=; b=S0wOhgnYKh5IW2tu 25zPa31Eji8X4pqfm4kffM3nmnyIHWqMESJr0aiaHw4TOJnV34XCSGMFRq/irS5r DjzbctXKUJTMymftW4sCUTm8g+nKYx8j9dU5uSrrvlHNit8xfHVQztEYJkCElCQK 2uCFvrhirJFhW6FC50Zq6MDlzr/uy+KPnYID8zVqCjDBSLWxun8dozTLpfbxOjll cvWUuazbK8hmxqKk2dxc5h4bgsRrgJQRcLdKBl87MjzpC52KKlTg4oNkMUcoxeem +oJjObYZJ5KqhmFFAxQkZGVrv8xa6lmuXQUDVuapOuqRNl4p6qITwvYXN8HHVMb5 5JX28g== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f43vfk817-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 14:46:43 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c07313be5so1875331cf.2 for ; Tue, 30 Jun 2026 07:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782830802; x=1783435602; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kM6XssLZS5uE8jkI5SWx0ezfn7uyBMeOizbquvZVlhM=; b=RAgj5rWSWnv/nqhQOR3AZxPvLILrVLJug1prX0W+qsphRc2boPYcw+DSrINeMvtLO8 SoMxLAqKT7xBBPVPMdEX3cdJBMDuA7UwVnvNiSnWAFcWDtManDKeFBZ/U6d/vU63wwU9 RiUHtlMb1go3vqRiFFShB/ILKl0ip04u+fgqJFvTnGjgiLudvmAxAkoWqHxwV0cCOqJM fEvAMIct+st8syMzjyX1N4xdI7mG5ZKQ/nePZppZhzsWHLCHNzYfkx1PMN09J2Aihwhj KTeGPgUIgBb+yeohb0Vat4r5cfWHt9/VUAKwttGEVYek5FVxIqaUcQVhNDLG0Bu7bR4I 4psw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782830802; x=1783435602; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kM6XssLZS5uE8jkI5SWx0ezfn7uyBMeOizbquvZVlhM=; b=UKonyr8rRPrM5BU//nO96qV8B+IPrOqJY9w1+gh/xaa7tfQHuCYKw1qNZ0VXpcjl91 xQntDeZOlJuEE7OstALCNRxdAGCbmVZtX34jp1j9+EyNcJngRgl4vZXpb33ZyAedjHya 1RyfkQyNLQCxGph2ddBdkaVnSOZalIT+It71MBt3ZO/YhKA8iwEp6ZDZnmDPl4ON2Tc4 Fyb9Tgs9eL/4UZd0R4AXG3vq+8OTM+UVzpxt7bHuyZyt88emV+ahG7PkIzM+yVvk+VFM HsFCe8g3cebWd3HIHsRvqGEuryZwSJ83/U2W3GwoJss7TuVI7+fMDuyGKWyhtA8mCTMd aOvA== X-Forwarded-Encrypted: i=1; AFNElJ8LoEkh43B02eGk6eyKMQrZ4S9lG/zvj6GWBKqMcpFlDk5KEIUHePF9w9+XAkkO1l+8xOWhwSDHuNUq9E4=@vger.kernel.org X-Gm-Message-State: AOJu0YytVsOVIJI/bWQ23Sth0toPb6zSY0mExtmMsA522IovQjqgH3iI bj0VxhI/PKBuzwu8MextT8Aw9jZ288ejQCNO2APr4DqnY1SYC42Qgm74SncPUzPg+I4GasVPMgb g4f2DGYcXWlB9N25mA3grx+p+PPQHv5KCQgAjEYpgUg2wi7CvvjhY+UIkVwjzL1bx85k= X-Gm-Gg: AfdE7clS974gg/KjYLmaUKgoNN9i6k8siR2EjT+VyFXqzsCA4MKlb8pupZ5WYEDWUTC goBDkeMJyn2O3aX0xWxIy+RwvSGtrG1SxJ4PfQNWtxo+kr61yc+p4KXzltyCAb/EjeP4YQj0HGZ pq67QgfvESnmgcVe0TpfP005SyZ9+Kos7OLPLAWGfXwnNxSKhk7cohqGiv6OlhwBri7LDZtA/sb 5BWSddzKTPvWIF4/6Z5nvIGnlyb3TKdRw69a731ncaUGPTFp2mbVPA8CW960Y8ADRykDVKey6Ps Awb8jz2UFIlqO5Y/76ZsqfaILIcitHFwGEIe2a2s+9NuB+RxZwhFhNy64PBvXVCZKXBMDVlf43j 4FijFOE8Jc12j2KHDjD2nGW7s3QoRPtjxqg8= X-Received: by 2002:a05:622a:6a44:b0:51c:1c73:51a6 with SMTP id d75a77b69052e-51c1c735368mr6822441cf.5.1782830802433; Tue, 30 Jun 2026 07:46:42 -0700 (PDT) X-Received: by 2002:a05:622a:6a44:b0:51c:1c73:51a6 with SMTP id d75a77b69052e-51c1c735368mr6822221cf.5.1782830801985; Tue, 30 Jun 2026 07:46:41 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288f0df9fsm142087966b.35.2026.06.30.07.46.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 07:46:41 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 16:46:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] spi: qcom-geni: Add property to force GSI mode To: Mukesh Savaliya , Pengyu Luo Cc: Dmitry Baryshkov , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260614083424.464132-1-mitltlatltl@gmail.com> <20260614083424.464132-2-mitltlatltl@gmail.com> <99eaf1d1-fbf9-4336-a13c-ae8ab789cc99@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <99eaf1d1-fbf9-4336-a13c-ae8ab789cc99@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: eLQipwv3eMxFTSGGZbx3Y_ThUYquTer7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDEzOCBTYWx0ZWRfX0xSkcUHKQpnS mIgg0Wp5ihU3ynrlCu2jp3HLSm+gmN8GFGN0kJ8cfqY/Q3YeDd0KZ9j7kWOEt43cCFzVdPIOBBB /XDNz0Lh0slqfI2Ok0n1W2jtDczyr1PTwaHSn6510w12wUlanMhLUGP9ceiv7GKjBrLHu13lOe3 bD7A530CDmBgiWNNkWXYyiAWZPgsEH6xEud7PK/cXESZ8IL8XoygT2tKohwvEsdwUI3y7Dzu5ds 0MnTjMz4TcPeGswU/wlZGFxCesMaDWYOFK8xXT/8rMZjg0C2YHE6Ta/UVoqD/OnCac2VRolLhb8 RuIWsrpIzmBOtP8g7syEhilYjDgmoRuxL/b628qAHnxJ0xLQ/LHFZ+Z1og+tvG9S9pH0gqLSmoj ZfJNwNa6+ydLkLfgrkUmGJy8wCuQfq+kA8oUM6fKUwxZBtEFsifb53w/5fSCBXwjejOY0Z1hn+R YwJ/T/uKodR2ZDFM9Fw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDEzOCBTYWx0ZWRfX+uTC1Mt2QO5r hGvYpG7vhKMMAoi7u3Iipslb/Tvm7gnpVFlzvbFDJmGKN0AtlbzateLWH2ZsOjnzLsbGfIUN9EO y81sbTkfnOs7WzFTM/5w/oCDKZ0zehM= X-Proofpoint-GUID: eLQipwv3eMxFTSGGZbx3Y_ThUYquTer7 X-Authority-Analysis: v=2.4 cv=PcXPQChd c=1 sm=1 tr=0 ts=6a43d6d3 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KdbZC8JMYa_JGPUaySMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_04,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300138 On 6/30/26 11:52 AM, Mukesh Savaliya wrote: > > > On 6/29/2026 1:33 PM, Pengyu Luo wrote: >> On Mon, Jun 29, 2026 at 1:36 PM Mukesh Savaliya >> wrote: >>> >>> Hi Pengyu, >>> >>> On 6/15/2026 2:48 AM, Dmitry Baryshkov wrote: >>>> On Sun, Jun 14, 2026 at 04:34:24PM +0800, Pengyu Luo wrote: >>>>> Some devices (such as gaokun3) do not disable FIFO mode, causing the >>>>> driver to fallback to FIFO mode by default. However, these platforms >>>>> also support GSI mode, which is highly preferred for certain >>>>> peripherals like SPI touchscreens to improve performance. >>>>> >>>>> Introduce the "qcom,force-gsi-mode" device property to hint and force >>>>> the controller into GSI mode during initialization. >>> Why to force ? You can directly configure in GSI mode. Note there are >>> some configuration done prior to Linux bootup too. >> >> Sorry, I don't get it. how? I know there may be a qupfw, but it is >> impossible for a normal user like me to generate one with GSI >> preferred. >> > If firmware doesn't program in GSI, you can't have this working in GSI mode, its going to fail (and work with fallback). if it's programmed in GSI, anyway this will run in GSI mode. So why to add extra things without any usage ? My understanding is that GSI mode works, but the the FIFO_DISABLE bit is set to zero, so FIFO mode is chosen. So NHLOS would allow the use of this GPI instance (and not reserve the GPI channels for this SE), but not set FIFO_DISABLE=1. Konrad