From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751374AbeABRbL (ORCPT + 1 other); Tue, 2 Jan 2018 12:31:11 -0500 Received: from mail-qk0-f193.google.com ([209.85.220.193]:40877 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbeABRbJ (ORCPT ); Tue, 2 Jan 2018 12:31:09 -0500 X-Google-Smtp-Source: ACJfBos2H8AwTU99PDE+cOGBVRncBsjur1K+FktqJhrGmCR3yxXpFvaf8S7ZFVWHaXv1RkIpfYEaLQ== Subject: Re: [PATCH] [v2] ARM: B15: fix unused label warnings To: Florian Fainelli , Arnd Bergmann , Brian Norris , Gregory Fong , bcm-kernel-feedback-list@broadcom.com, Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20171218165307.1472231-1-arnd@arndb.de> <608efeca-c913-5f38-565f-9f792b51fae3@gmail.com> From: Florian Fainelli Message-ID: Date: Tue, 2 Jan 2018 09:31:04 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <608efeca-c913-5f38-565f-9f792b51fae3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 12/18/2017 05:21 PM, Florian Fainelli wrote: > On 12/18/2017 08:52 AM, Arnd Bergmann wrote: >> The new conditionally compiled code leaves some labels and one >> variable unreferenced when CONFIG_HOTPLUG_CPU and CONFIG_PM_SLEEP >> are disabled: >> >> arch/arm/mm/cache-b15-rac.c: In function 'b15_rac_init': >> arch/arm/mm/cache-b15-rac.c:353:1: error: label 'out_unmap' defined but not used [-Werror=unused-label] >> out_unmap: >> ^~~~~~~~~ >> arch/arm/mm/cache-b15-rac.c:351:1: error: label 'out_cpu_dead' defined but not used [-Werror=unused-label] >> out_cpu_dead: >> ^~~~~~~~~~~~ >> At top level: >> arch/arm/mm/cache-b15-rac.c:53:12: error: 'rac_config0_reg' defined but not used [-Werror=unused-variable] >> >> This replaces the existing #ifdef conditionals with IS_ENABLED() >> checks that let the compiler figure out for itself which code to >> drop. >> >> Fixes: 55de88778f4b ("ARM: 8726/1: B15: Add CPU hotplug awareness") >> Signed-off-by: Arnd Bergmann > > Acked-by: Florian Fainelli > > Thanks Arnd! Arnd, if you have not done so already do you mind adding this to Russell's patch tracker? Thanks! -- Florian