From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4242B3AB276 for ; Mon, 23 Mar 2026 13:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774272729; cv=none; b=eTx+PCLNxrGvYGibG3MoahH37B5Gc9gmqQBDZSUzYSL/0BkfpZR9XkGJRMc1YehrJ+JoGtJfx4pZLdyLErXHiJAUwuONMyWAWjvg2qcAD/lYRPVSg0+qrCRSComdZGZudNqlkSJFKlfH//L4QAWwUuLZxxzqF11h0mf0Ej85DDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774272729; c=relaxed/simple; bh=6vjop2NB0D1MRePv/+1HQMTXD3X7VbSW6gezd2Jkz5o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MnTNz3MrhR3t5IOGqwbdCWcZOuVM42MeeCLZ4OJza3gs+PC1rtiSemQoZIZCaLblUl0fNHe2XOIoxnMn9B1P6poymDsFWc+nutMvwGcy/WTqwPayGFsB3Npo45eZqfWwi7W4u4VaGwy4PnfB7R1vu3OwT3WmrPXgfmCBaK8rKQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=o14ItgrV; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=kTQmBeXh; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=o14ItgrV; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=kTQmBeXh; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="o14ItgrV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="kTQmBeXh"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="o14ItgrV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="kTQmBeXh" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 61AB44D332; Mon, 23 Mar 2026 13:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774272726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=emLcoP3+QWMocUpA4HHuhySiNMMzR708E8k/Un3od0E=; b=o14ItgrVMvI/5gdDDfjN8T8Ie9yi3TUQxdxW6V4ovo0pjvDzLhhjiWT3NmjcmmDCVjyUoq Om0edd9zoeKMk12mALjyh9SBq9dza2Y4vXMrok05CkwCulgxhcpz+3KwSRwM+14jgTXihS 9UdhR6yo2Ce0ndj9mCvOxAc/TbDJLCc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774272726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=emLcoP3+QWMocUpA4HHuhySiNMMzR708E8k/Un3od0E=; b=kTQmBeXhr/GBx3FErDD2XaCm06ukHW9V+2D65TdBXQxEqwySbRCAIXiGT8ROW//BJO5SsI CF7N+bUyQBvjbsCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=o14ItgrV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kTQmBeXh DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774272726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=emLcoP3+QWMocUpA4HHuhySiNMMzR708E8k/Un3od0E=; b=o14ItgrVMvI/5gdDDfjN8T8Ie9yi3TUQxdxW6V4ovo0pjvDzLhhjiWT3NmjcmmDCVjyUoq Om0edd9zoeKMk12mALjyh9SBq9dza2Y4vXMrok05CkwCulgxhcpz+3KwSRwM+14jgTXihS 9UdhR6yo2Ce0ndj9mCvOxAc/TbDJLCc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774272726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=emLcoP3+QWMocUpA4HHuhySiNMMzR708E8k/Un3od0E=; b=kTQmBeXhr/GBx3FErDD2XaCm06ukHW9V+2D65TdBXQxEqwySbRCAIXiGT8ROW//BJO5SsI CF7N+bUyQBvjbsCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 167DD438D0; Mon, 23 Mar 2026 13:32:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id T50mBNZAwWmnYQAAD6G6ig (envelope-from ); Mon, 23 Mar 2026 13:32:06 +0000 Message-ID: Date: Mon, 23 Mar 2026 14:32:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/loongson: stop to set get_vblank_timestamp for LS7A1000 CRTC To: Icenowy Zheng , Jianmin Lv , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Qianhai Wu , Huacai Chen , Mingcong Bai , Xi Ruoyao Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260321092804.3519447-1-zhengxingda@iscas.ac.cn> <47337244ebd0ce4efd3e065183e863421925f99f.camel@iscas.ac.cn> <4141b0a640f4d703053dad2c1dd257835881f0e2.camel@iscas.ac.cn> <681588dc-b4d9-4af4-b6c0-c117024593df@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_TO(0.00)[iscas.ac.cn,loongson.cn,linux.intel.com,kernel.org,gmail.com,ffwll.ch,aosc.io,xry111.site]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.com:url,iscas.ac.cn:email,suse.de:dkim,suse.de:mid,suse.de:email]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,iscas.ac.cn:email] X-Rspamd-Queue-Id: 61AB44D332 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: Hi Am 23.03.26 um 12:42 schrieb Icenowy Zheng: [...] >>> drm_update_vblank_count+0xac/0x418 >>> [    0.334960] [] drm_vblank_enable+0xf0/0x288 >>> [    0.334960] [] drm_vblank_get+0xf8/0x160 >>> [    0.334960] [] >>> drm_client_modeset_wait_for_vblank+0x50/0xa0 > I doubt the problem here is that the function above is called with > hardcoded 0 by drm_fb_helper_fb_dirty() (being inlined into > drm_fb_helper_damage_work() by the compiler). Then on my setup it > failed because my primary output (laptop LCD) is on CRTC 1 (CRTC 0 is > external HDMI instead). The CRTC 0 has vblank interrupt. The CRTC 1 does not. Is that correct? > > This is new behavior introduced by d8c4bddcd8bc ("drm/fb-helper: > Synchronize dirty worker with vblank"), and the commit messages say > `This allows several screen updates to pile up and acts as a rate > limiter.` . This should work if the vblanks are configured correctly. > > Should it wait for any vblanks instead of waiting for one on CRTC 0 ? > (Or check whether CRTC 0 is on before waiting on it?) It should only wait for the vblank on the CRTC it uses (1 in your case). Best regards Thomas > > Thanks, > Icenowy > >>> [    0.334960] [] >>> drm_fb_helper_damage_work+0x8c/0x1d8 >>> [    0.334960] [] process_one_work+0x198/0x348 >>> [    0.334960] [] worker_thread+0x238/0x390 >>> [    0.334960] [] kthread+0x160/0x198 >>> [    0.334960] [] >>> ret_from_kernel_thread+0x14/0x1c >>> >>> [    0.334960] ---[ end trace 0000000000000000 ]--- >>> ``` >>> >>>>>> Signed-off-by: Icenowy Zheng >>>>> Oh forgot to attach when crafting v2: >>>>> >>>>> ``` >>>>> Acked-by: Thomas Zimmermann >>>>> ``` >>>>> >>>>>> --- >>>>>> Changes in v2: >>>>>> - Re-formatted Loongson product model numbers per request >>>>>> from >>>>>> Huacai. >>>>>> >>>>>>    drivers/gpu/drm/loongson/lsdc_crtc.c | 1 - >>>>>>    1 file changed, 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/gpu/drm/loongson/lsdc_crtc.c >>>>>> b/drivers/gpu/drm/loongson/lsdc_crtc.c >>>>>> index 587fbe285e9ef..b3af8e0cdb15f 100644 >>>>>> --- a/drivers/gpu/drm/loongson/lsdc_crtc.c >>>>>> +++ b/drivers/gpu/drm/loongson/lsdc_crtc.c >>>>>> @@ -721,7 +721,6 @@ static const struct drm_crtc_funcs >>>>>> ls7a1000_crtc_funcs = { >>>>>>     .late_register = lsdc_crtc_late_register, >>>>>>     .enable_vblank = lsdc_crtc_enable_vblank, >>>>>>     .disable_vblank = lsdc_crtc_disable_vblank, >>>>>> - .get_vblank_timestamp = >>>>>> drm_crtc_vblank_helper_get_vblank_timestamp, >>>>>>     .atomic_print_state = lsdc_crtc_atomic_print_state, >>>>>>    }; >>>>>> -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)