From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8767339183A for ; Fri, 31 Jul 2026 14:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785507181; cv=none; b=VjYLGrjrCWuvaDEr93y7bUfoRyVYwdwUyH0Q5ewglJTU7a6Qn00LWuGlfdlPc5t489A2j2T1YZLfafaMITD9ykKGdOA0cgTOh6N4Kn15q3146Y6jMrTAWCckrU75xHbjUHzIw/JFaz46P4w14F4Hcl1Vo9tUO0PBBSOpPkLcHwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785507181; c=relaxed/simple; bh=0aDIb0fU/IpGonH1K4ihI7im17zW2pGOollQDCIp11k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZSzmeEKILWhN67MXMRmCCRcZhfc5FaKNMjkgu4Jym8SkS+3qaAign2YF7G4Pthj+A3UOq8wmf+nobXckaFqORsLLSo6sS59bSdZAjTBCWEH/DOyc6ljjo8I3/yT9gX1UrbOeVflcXl+agTGerOPJKr2eV/mEQhqLLVpdwcL3Q8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oOFn3Fnd; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oOFn3Fnd" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-38e88b60121so856524a91.3 for ; Fri, 31 Jul 2026 07:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785507175; x=1786111975; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qls6m4+nvnABe9mzo/b58dSKb8hrptf8rR5t44pPd/I=; b=oOFn3FndSk4G3HLjh5mk9NGqmN9B4eW6Gl+m4Ti6JpF2XMAkZBGwUFFwnTcIRV4qtm tIXReAui9olvCHHShsFpGwWbLOFifngl1qKqNHBzrBqlluPipRWcky2tnRHBherIP5lM nxsk38LeNFSRK17XfA/mcwr1vjwWpMird33nCSluRp5zp50VDRJLUeumkf/N7uczVUD4 n8zbrzO48ppfajJlhHLboJePwlMZpuzjoivsYxXMy9+WKsh2og8MEuNvjxRVxRkzS0Ca poxvXzxTlbb5p3+v7jOz2BzWRlroTi7J7uKn1Mr8PZlDX5VxJkxkGD+CI4LYWxthg+0s gdMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785507175; x=1786111975; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=qls6m4+nvnABe9mzo/b58dSKb8hrptf8rR5t44pPd/I=; b=Rfp1rqFK8nrSY2VczmV1uK/6xxRPIuuVAL5k0e6SmCdSjhNT/yYWODnKJq7kQwgcoe HiY3FvAY1HeGJd1In7lSHx2CNVyhTXYwADZExfFFRX+Rwje+Gdgg7Qu5iiIiUpQR+6Kh B7+/DMqZwLdJO9hI87KFnqtzccx6nTKrtZbXLF9juRGtG2oBTSNQJrhbUBpjWltJ5bNr tKuJG3MiVy4EtK6t/Cw66CdgudHnCeUkPoDVNWPkW94qIPHzwoSuHNyddAqR3HIkZPeB H+6lwaYDrip127hhjOPElFbjWC3xdBp1kTveGBVb1R+h6/6/YPbZq+F/sdoop1H0rcoj p+6g== X-Forwarded-Encrypted: i=1; AHgh+RoFP8L/TpzyP4HriMtjQnF4yE131jG2Zb6jwTQUpu5yNYCNf6RXZERXvHLgOYGBk/ySC7HeFfJKWlkA/k0=@vger.kernel.org X-Gm-Message-State: AOJu0YyZf0x7RAuQBNKBTVzWeLG5JH56rNk3J3TKteXtja6inDPg3JUG MhkUH/CVeRNqcHP4SXl2EqowIFPaiKWTytD6bCqzCUaMJQ+HL3VAfxbO X-Gm-Gg: AR+sD12c5qSMHUMctPXPoV2k1T/3pjzEnyBWN+aN//malESyAZ4ZffsnNRSH4a9ZxnD 4pyc9I3iFmm005A/9UapDstoRJt8Zr2PHyR7QL6A42vuD4f8MtOzkuRJVXYrac17Mmw61LsokV3 5hLLBQ20MQ0xV/8kKqgS0sLTqKsdRlmJZnZZv5kist7EJbnM1A/itaElXD11stG/m6iTuyJe+ZD Mq2DLy88XieIpt9BJKo+TB1s5kBdulN18neopGRtYqs6RsEl2UJgTIiYmBh6jExCmFF+cQiY/GT JrzD/koogyjPRH2te6cvgLciVMtwqbgWnGKkyAax7eI9RvT8faathLORaxIxvzfZEWo/AHjsGgo OcrOaw4bLCXeBEusT78mwHkQ3XH0LX/JjxhKWxQzFGBj8bzAkqIzAShhwbdHzbKwItqr1yxpDsk box5qRfwuFpHz6U2WNhA5s2ZH3u+q+XgcLBP+y4IlMw+WiXNSTHc4Aa4/5whKPbbV1BsYJLyomo a46IQj1hBepfvWxx4eSjMYYXX4MHYOOl0H/ptnAQALwgFde X-Received: by 2002:a17:90b:2d4c:b0:387:df8f:1401 with SMTP id 98e67ed59e1d1-38fbc598becmr53602a91.34.1785507174623; Fri, 31 Jul 2026 07:12:54 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb2964c10sm763044a91.4.2026.07.31.07.12.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 07:12:53 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Fri, 31 Jul 2026 07:12:52 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] watchdog: qcom: Register pretimeout interrupt as NMI To: Konrad Dybcio , mrungta@google.com, Wim Van Sebroeck , Thomas Gleixner Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, "Kirill A. Shutemov" , Douglas Anderson References: <20260730-qcom-wdt-nmi-series-v1-0-3aa86d162914@google.com> <20260730-qcom-wdt-nmi-series-v1-3-3aa86d162914@google.com> <36a7bd8e-7e00-4df0-abd4-e22b86e91ca4@oss.qualcomm.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <36a7bd8e-7e00-4df0-abd4-e22b86e91ca4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/31/26 04:56, Konrad Dybcio wrote: > On 7/30/26 11:32 PM, Mayank Rungta via B4 Relay wrote: >> From: Mayank Rungta >> >> When a system is completely unresponsive due to an interrupt storm or >> deadlocked CPU cores with standard interrupts disabled, a standard watchdog >> pretimeout bark interrupt will fail to execute, preventing the pretimeout >> governor from capturing CPU backtraces before the hardware reset bite. > > [...] > >> drivers/watchdog/qcom-wdt.c | 55 +++++++++++++++++++++++++++++++++++++++++---- >> 1 file changed, 51 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c >> index 49bd04841f0c..19d8e91cff40 100644 >> --- a/drivers/watchdog/qcom-wdt.c >> +++ b/drivers/watchdog/qcom-wdt.c >> @@ -51,6 +51,9 @@ struct qcom_wdt { >> unsigned long rate; >> void __iomem *base; >> const u32 *layout; >> + int irq; >> + bool is_nmi; >> + bool irq_enabled; > > Do we need to track this? I think we can rely on the framework > NOPing out multiple ops->start requests > Good point. Agreed. Guenter