From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E29E3280A58 for ; Wed, 31 Dec 2025 16:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767198091; cv=none; b=f0FFWMLovx5URx9Wn43EJEgH0ntwqMlO8asj5TlVP6oywBD79yBjiWBEbsoLR4U8ssjTUHX0Q+TvdyCj6A5XouYAMaqvdE88yQVmc2rvtulFXezUE37bhUcsDn3N3nTC0nyUFcOR1t302PdBT/JrWeoETzz5gwRDhz40jvRSRn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767198091; c=relaxed/simple; bh=PQPa+CUN7MPer5fnijIcj01pN0ziayfCVivvOD3tkS8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZjANThoO4ED9/QIlDxJbdFC4NlRZKfvPWFAF2EEoY8EeCxA5u1nt6hiphvQ91wlzfKSRMkmL9p36gufLaVQTkUVR9a0YvYMqhdEdsqcyRPo0I8IlLX0jMDSS4ULnmYQvoduwqxZru90sg47HmIArto6owm00/ctzt7Za9Ch3iXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ULNrxI+8; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ULNrxI+8" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-3e83c40e9dfso7167042fac.1 for ; Wed, 31 Dec 2025 08:21:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1767198089; x=1767802889; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4VxsJvPd3cI1KTNnl7L01TZ9c0Oijs9ErHb2bvB+BxA=; b=ULNrxI+8LFnWqLnRNZfMKZ8ZXJ4y4RR2mCoVMiB9Wq0k6HkNay372LWuqdnv1tfXhk /SP0jf8RsooInyZaqdox1vv+HcjBFfxKHAJPr6y9fsinQYOxzOEFzSHbkSquMPgIHfoZ YVtqoZlZFwPKaEooJkCeJaz3xOUkgAJM4xB+4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767198089; x=1767802889; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4VxsJvPd3cI1KTNnl7L01TZ9c0Oijs9ErHb2bvB+BxA=; b=ftBOGd3C/1K24eIbEPS2YHqmhOqso38KCpqc9eYxqM4OTeYSzwL0ZUrsGj0lzpSUTL lKiRHnDUc1RA1SbF/uhwaquA0+YU8ZgjBoJIhFdP+cIpaMeZPBUDcNSf6QUXy++uZ4s4 2ci3j0W2we2MfF4U2nXqUinq7we5/6MoaQ284MSJJVYcbO9ao+EfQrIoND0UgGE5sv7e UmUhPLncxjSuPoRbsWIK/TfaqeMDp/+BOQWbudyAlaQ8nxiiji16YA38EmCVLKFLCPl4 WPlfF1wk9qnS/m4ndDeqSYx1USQssTmEUTcc5P2CNOSjfXb7fcy7nM6uFnNq7Xck/cHx Lfsw== X-Forwarded-Encrypted: i=1; AJvYcCUggvfbww1znkNbzk2o0rofz/E/yoAD/uhZ+cYJR3VdxRGF0St3cDnwHTm3/HyapmvaUm6Da3jvFG/ZuVY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3x5tqs8sCGAoQRTImW4/Yos7rK1x533FOVDA6OU8R6C43QY2Y LH8rT/j12cb1VVOJfJndzJustSc+68qtg77JK85Kkjvb7wzysUZ90D2eUnL2tzp6hY4= X-Gm-Gg: AY/fxX65rF2M0QOjJrK5OJjqxBgRVmbIN+PLHDmNP+URaj7Y5ySvKgg6g1Peh+NULdC WgzHOplPiRYfdkZQCqDty73Fk38F9oxesW1dhrQVFqBv+Cgby2NFx/YzPi2UAb3YNiwQPVtWlHA +msJLIanfUomuoh3SV++SGSVYdN1BqJ/WM2fyYDml+TvDbRHwr8fu+syzNFJSCAL41hu8MtiL5I /BFQZLBG3P/nQms9O9HjrWzF/km7qbjvxcdbn+tF2mV4Nn9ZS1LyRvQqevOOFb9uxLEzBqMOuqO 3U0P2q3zDaNGjltgehXLSPM0fGjsPMII15WRwqBK308MubdbkjVqF8nLZ9OFsl5mu9pRhlR0xn6 kHwLUEXOOwqXlTKL7PHu9s3+3VqCIGuY5uxecxUtszTxDIL5sdtxHgsnsa/XQuY77Wwq7ZmEF6c V4H3tTWLOnEmP3b4zk560MDks= X-Google-Smtp-Source: AGHT+IEHyGzJlX9BG5IGxQWI+udvuX8r10ycrsNMN1UZ5U1HR75+jvZ88LGIfUUEQ4FL5FGJJHzKPg== X-Received: by 2002:a05:6870:c18b:b0:3ec:321c:b2ac with SMTP id 586e51a60fabf-3fda580edb0mr17664156fac.37.1767198088781; Wed, 31 Dec 2025 08:21:28 -0800 (PST) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3fdaab65763sm22362927fac.13.2025.12.31.08.21.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Dec 2025 08:21:28 -0800 (PST) Message-ID: Date: Wed, 31 Dec 2025 09:21:26 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux 6.19-rc1 mediatek mt7921e broke badly To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: Matthew Schwartz , Linus Torvalds , Eric Biggers , Mikhail Gavrilov , Mario Limonciello , Johannes Berg , quan.zhou@mediatek.com, Felix Fietkau , lorenzo@kernel.org, ryder.lee@mediatek.com, linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , linux-mediatek@lists.infradead.org, shuah , Shuah Khan References: <756e3f65-b2f2-4da3-985a-17754a7a872d@t-8ch.de> <6fc04df5-b753-4b2d-b978-0e59a7f48ff7@linux.dev> <8c8c8f27-ba44-48eb-96f6-dae6d2d0cbf8@t-8ch.de> Content-Language: en-US From: Shuah Khan In-Reply-To: <8c8c8f27-ba44-48eb-96f6-dae6d2d0cbf8@t-8ch.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/31/25 03:36, Thomas Weißschuh wrote: > On 2025-12-30 16:57:20-0700, Shuah Khan wrote: >> On 12/29/25 21:21, Matthew Schwartz wrote: >>> On 12/29/25 4:41 PM, Linus Torvalds wrote: >>>> On Sat, 27 Dec 2025 at 04:25, Thomas Weißschuh wrote: >>>>> >>>>> Hi Shuah, >>>>> >>>>> On 2025-12-27 02:07:24-0700, Shuah Khan wrote: >>>>>> mt7921e doesn't load on my primary laptopn on Linux 6.19-rc1 and problem >>>>>> still there on 6.19-rc2. >>>>> >>>>> This should be a duplicate of >>>>> https://lore.kernel.org/all/CABXGCsMeAZyNJ-Axt_CUCXgyieWPV3rrcLpWsveMPT8R0YPGnQ@mail.gmail.com/ > > (...) > >> Reverting the following fixed my problem. >> f804a5895eba ("wifi: mt76: Strip whitespace from build ddate") >> >> The above fixes an extra newline in the dmesg by making the >> code more complex it needs to introducing local buffers and >> strscpy() - the proposed fix replaces this with memcpy(). >> >> Is there a simple way to do this than introducing memcpy() >> or strscpy() to remove an extra newline that might or might >> not exist? Why not check if newline exists or not using >> strstr()? > > We do have memtostr() which would be a perfect fit to use here. > That is still a memcpy() under the hood, but the code is clear and safe. > It does however require the source to be annotated as __nonstring. > Which also seems to be the right choice here anyways. However for > consistency, all other similar fields should also be annotated in the > same way. So it is a bit of a larger change than a pure bugfix. > I am playing with just removing \n from dev_info() - there are three dev_info()s in the same routine that print the same information. I will also take a look to see if they are indeed needed. thanks, -- Shuah