From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3BE91DF75B for ; Wed, 29 Jan 2025 16:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738168590; cv=none; b=MxrPIKnPpw3q5LAsAaxDEIVuJXWfl4Q2LGwyJHBdo1CSf0wftMKj0tnBnjHZJqmtqlyaLTHND0ybvst1Q21+s30EG/giiA39kJTJT9mM+hUlSINCIz+qiYhV3gCf8uttu6QW3lQ9rDVbPKFqH8iP99xG4whM4lI4t4hT53Gr7mI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738168590; c=relaxed/simple; bh=/ngpTkZA5Etsi4snBaz9y8U9cdHCuwUg3xomB8IxmAo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mGTrrVNTzYu9w7ujkOiIuJzXrBmtNn8hClEHSratTl5EbkR4R9Dzlq1g2PPf76I+gWwbX6YaFu6SnRCksCqQW7s4n23HVU7YOxh8YL8gnBplquE7fJNHtk6lcHrY1/mAu6Qd+W2H5YhBY/ds1OIg8YJcEI2LwR8kvEoqwJTqYS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AeJGqTsP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AeJGqTsP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738168587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uf0IlGh/gjSn7Uu9E43KL/r/UjxX90TchO2Vse1ONXw=; b=AeJGqTsPh2sAHfrQdcOZRJG0AHIZlntQSC6puUyBSbAcpxE+9dSmg2pmYkKorcN5PDvuC0 CsAJe2vDCqZyHFr5uANTZ+c8AM1nFOULRmhuxOEWknR40E5uZbQjD3kGko1rix2CbMiQpH F0++2vhFPDVOLYxzm50gVx0F2Ol9hDI= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-nVkj4FnENlOKvavT5IKd1Q-1; Wed, 29 Jan 2025 11:36:26 -0500 X-MC-Unique: nVkj4FnENlOKvavT5IKd1Q-1 X-Mimecast-MFC-AGG-ID: nVkj4FnENlOKvavT5IKd1Q Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ab693930fc5so357468866b.1 for ; Wed, 29 Jan 2025 08:36:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738168585; x=1738773385; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Uf0IlGh/gjSn7Uu9E43KL/r/UjxX90TchO2Vse1ONXw=; b=dzQuHArXFklr5XsCq9kiGTN0UTiB+mpZwC03I3OHS4RGoKaUhoS4Q1GG51jVhOIQI7 RKF/2/8qqZWTCbtw8CIdOrXyDv7osKNO2/p2tH6xQj6krluARNxsR1OtEBMgDLoDTaJt FuOd4KDtxq+UMns6kUpxVQ+Zley7vMQ09t0oAeq34zdsCZkKG3lTR+65DSYdmhrabKqo ZnpY4ui9DG2KlAOSQnYrFvXl+wMu4yH+3qLj6KaZW9N66+zcFJQlPG34FgovTE3/6x3J ymbWrnetWiov5iTVIFt5g5AlVWnYk2raUbQCExqrVIlXgWIp7cjFmlypJTCYNANqOvI4 q2PQ== X-Forwarded-Encrypted: i=1; AJvYcCWdxIGqfWvjLPO+8TRczqmba25KLMzkz08/5JnbevaIJpnDPN8hiFywahUcEMJTI3Kit8LrsFvYHfR7PPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwznRECjdkyYS0NZ2X57zzwSwKNXMkTWSAyWQgJZU2B1P8BEC2T Qfguntcayq3VsNHnSucE8bBziXUuqGkwOteM50lCKWYcYaYr9j3qjhUiqGXyt3wLFRwDGvwE7Ir EkrXKt/NalqdwoSI8kt3PRlvd2x6etIZw4mvZe1Q1qq7y7fZDKCrGIEzhpl4sMA== X-Gm-Gg: ASbGnctRFIqAP9BG12fkt74vSIqO07ZYxkyq4Wqkl7uiOG6RO6JGJb+kOJ9qcevWJbT sO3yj4F4kyQn3+na8TWLgo6sfJ1voxGizo6HXiL/29mvZiO5CxnLfG088SxRHvz0jt4GIpt1lK7 nPlEn35Uw7AFXhd9njBiK3jPPS3tvJOE90nz46n+wRLZbFXVqzDaCGk3/CZlEjnDCBuZxSqcr2x Txn26Oqn3BceqxX97qZGREv6jo48pJf5XT9af5KTx2FUzNT/HpkcxcPViLz5ubxZHQQ/2/X1Pmf MJcQKyTMzG8EAz3+7QHplX+1Wp8DKhShk92NeQpS8bx3uoJK0vVPSKnqU0Sx6dGDoAdP5M4gU5w zDbIZOS+J/udUo6QeEsmRErb7rPd+/WuqGc1wSJ++ta+hE6e/oJoeUuY= X-Received: by 2002:a17:907:3e0b:b0:ab3:a3b4:f91c with SMTP id a640c23a62f3a-ab6cfd0c96amr389630666b.34.1738168584898; Wed, 29 Jan 2025 08:36:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3Cu2DvLHeOnl8tBasvD2StDx4qBidvOxQMoXLaljViC5Ciq8Uq0e74TEu4x71DYc1yFFRiQ== X-Received: by 2002:a17:907:3e0b:b0:ab3:a3b4:f91c with SMTP id a640c23a62f3a-ab6cfd0c96amr389627266b.34.1738168584446; Wed, 29 Jan 2025 08:36:24 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6760fbb72sm990753166b.129.2025.01.29.08.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 08:36:23 -0800 (PST) Message-ID: Date: Wed, 29 Jan 2025 17:36:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type To: Andy Shevchenko , Lee Jones , linux-kernel@vger.kernel.org Cc: Andy Shevchenko References: <20250129152828.1802315-1-andriy.shevchenko@linux.intel.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20250129152828.1802315-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 29-Jan-25 4:28 PM, Andy Shevchenko wrote: > REGCACHE_NONE is the default type of the cache when not provided. > Drop unneeded explicit assignment to it. > > Note, it's defined to 0, and if ever be redefined, it will break > literally a lot of the drivers, so it very unlikely to happen. > > Signed-off-by: Andy Shevchenko Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/mfd/intel_soc_pmic_crc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c > index 879fbf5cd162..41429f9bcb69 100644 > --- a/drivers/mfd/intel_soc_pmic_crc.c > +++ b/drivers/mfd/intel_soc_pmic_crc.c > @@ -113,7 +113,6 @@ static const struct regmap_config crystal_cove_regmap_config = { > .val_bits = 8, > > .max_register = CRYSTAL_COVE_MAX_REGISTER, > - .cache_type = REGCACHE_NONE, > }; > > static const struct regmap_irq crystal_cove_irqs[] = {