mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>
Subject: Re: [PATCH 1/3] f2fs: avoid using __GFP_NOFAIL
Date: Tue, 7 Nov 2017 00:29:16 +0800	[thread overview]
Message-ID: <f9aabb16-a4a6-0028-b04d-e4410257f622@kernel.org> (raw)
In-Reply-To: <20171106162303.syinckwdtdlwmeeg@dhcp22.suse.cz>

On 2017/11/7 0:23, Michal Hocko wrote:
> On Tue 07-11-17 00:08:25, Chao Yu wrote:
> [...]
>> BTW, I notice the comments of __GFP_NOFAIL, what does this mean?
>>  *   Using this flag for costly allocations is _highly_ discouraged.
> 
> This means that using __GFP_NOFAIL for high order allocations
> (especially those with order > PAGE_ALLOC_COSTLY_ORDER) are highly
> discouraged because we those are quite hard to get and looping inside
> the allocator basically for ever is not a wise thing to do. That being
> said replacing __GFP_NOFAIL by an open coded retry loop might make sense
> for those e.g. to check signals or other termination conditions.

Clear to me now, thanks for your explanation and review. :)

Anyway, let me update this patch.

Thanks,

> 

      reply	other threads:[~2017-11-06 16:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05 13:53 Chao Yu
2017-11-05 13:53 ` [PATCH 2/3] f2fs: trace checkpoint reason in fsync() Chao Yu
2017-11-06  0:55   ` Jaegeuk Kim
2017-11-06  3:10     ` Chao Yu
2017-11-05 13:53 ` [PATCH 3/3] f2fs: keep isize once block is reserved cross EOF Chao Yu
2017-11-06 14:08 ` [PATCH 1/3] f2fs: avoid using __GFP_NOFAIL Michal Hocko
2017-11-06 16:08   ` Chao Yu
2017-11-06 16:23     ` Michal Hocko
2017-11-06 16:29       ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9aabb16-a4a6-0028-b04d-e4410257f622@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome