From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A126F24C664 for ; Fri, 2 May 2025 12:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746188835; cv=none; b=Lzwdb816vw2GP7Zh9m6oSmtAnI+o9++JbZHEF3e8zI3/Pq/Htm2KHmwHOnMVYe55tUmjOvc9rJRYnkQSZPL1+JPTBgD5HBrEzCTS7OUjH5uYqaVUZPIv5eponjQjK6442Sg9cNoUC7hBE+Ci+3CspFrKhrTCSDRt4/pAYVK3hR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746188835; c=relaxed/simple; bh=4j0ke6M74LzeHhABdWPG4BsNF7G/ublzVqyQ3s3Ax4Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Af/AV9i6b2q6vP+obVYROr/tqqJxeUeXWYsk9EhIO18FabHRJupAY4cuzSIjbTb7CzfAewlhKLkOzqZxFcNiPRDg4c87nxO+ZSyxPQCwpEbk2oOQJbsEeNmFWCMxNpSsgjr7IatIqY3AVmOjyZppB+QJN1NSfAq8UB7cKRnxLAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Qu+snUZf; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qu+snUZf" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so11527385e9.1 for ; Fri, 02 May 2025 05:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746188832; x=1746793632; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iiq8j9Pd47tWgmGC+T98j/M88SapfZV3x181EBl9QGk=; b=Qu+snUZfbjtoVHbcYIQkh66FZYcCBl7m5EF3ECu929XCegVlhLstjeSVuXsnOSmYPu uK3OrOwh9X1eM9ft7gxS+vycMgMzSh/yRCFtydnKZNhlCYg9GjpU+W0fJtmadP6ri8lY TX+XpboqoObN+oLy9oMPr/E0kjSbSh1l3ILCcVUCS0BBP1q3/2Ftsk042J6+LvdC/Stw jRUEbok951xF3NkH1LZ1vPc53qli4lt5pHLGAI9cKK/thS2W7PE4d7bBG6CL1HOE8uKt 41bb76B8KJXkL03ezEXzv+/BxblbOxKjXTlTc/8J/qK5Rmw8JAoSGzrrpUCaX9BVgrDW 13/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746188832; x=1746793632; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iiq8j9Pd47tWgmGC+T98j/M88SapfZV3x181EBl9QGk=; b=TEQp85+66xK0msQkzRYnhRw+vOrGJNXQKj/aozfHJApNvNSP4qmDGR1ZHvvSoyj//u bOmh5mo+/UU8awvvrSnIuLCQh6Y25tGJLeOkjwm2KoqD2AGFdck9fERdwXP95Xk39b93 jEbOBeIpyNzm/EYIujQrUH04lVOZtvLO/b/XHmM+upAU7j0/RGR2BjODPGu3Mvsp3B2U CoCADo/FRSP9Opqi6uBIJJrd1hr9pPHNJ2R8eXqAOrciwrQ4p5GmpTvVk+kDVVBj6vL/ mGrHslTNnW3aT+P4noExLeeiTgangqG2FoiTOenJNgOxOxrMhcR4nwXjDeG8SRgCnRJ9 cUVg== X-Forwarded-Encrypted: i=1; AJvYcCWRC6J7uRMDayv3uS39oEXe3FBkyuv3c9Pcq14mlytqdxP7jpx7hTpNL5LhGkfxz5Yiocriy7YJ3N9fwhk=@vger.kernel.org X-Gm-Message-State: AOJu0YzPFn2i3+n6BYJ8Jz5As8tbICopVCmHMcuG3hVDjjYICd5UmLKq yTsrt00nR+SAT3uxkUiL9gBkZR0nEO2cVkD+f3anrYk1JVXnUGFIUxESGQvntGc= X-Gm-Gg: ASbGncskxnC2UQlQdT4cldsY+B+KhtUxu9x8F0Be+mZpa+QRWzLXieszTVhJg3iBnwc yHoQTQsqqZ2D5vzz8D6cRowI08Ddsg674MQKd7QvYiGtnoybwAgrhxsV72K3VPykTY07ieZQUgo 2AL+UFvrvnTw4YThb0wLiIGbGyL87Mbl67DpkfxgNrRrE1qIkgXuVqQb5NxDUrkoTmRNqluOavI Ilw7mmsB50IGyGbhRRaONGkLe3uo0+izUS2oaVQHiNA9fvCJGt/M2p66TsX/pWXMlM47PjAYN/+ 5TSKITX91qJKIb0px1/DcqMu+i7TuRcijxr6QjDCGrcG8IVllQtfl7h3gwb4EKct7pbQhUGkHzP 0IRIaGQ== X-Google-Smtp-Source: AGHT+IGffAlOpctwFrMNNY2tP4nZNI3nScrTpOCK1t0L/nEK+69qoAbndAyafnHVDnbgh0OsuB9ujA== X-Received: by 2002:a05:600c:15d3:b0:43c:f3e1:a729 with SMTP id 5b1f17b1804b1-441b72dc612mr34423725e9.12.1746188831814; Fri, 02 May 2025 05:27:11 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b17017sm2052074f8f.92.2025.05.02.05.27.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 May 2025 05:27:11 -0700 (PDT) Message-ID: Date: Fri, 2 May 2025 13:27:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/23] media: iris: Remove deprecated property setting to firmware To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Stefan Schmidt , Hans Verkuil , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Dmitry Baryshkov , Neil Armstrong , Nicolas Dufresne , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 20250417-topic-sm8x50-iris-v10-v7-0-f020cb1d0e98@linaro.org, 20250424-qcs8300_iris-v5-0-f118f505c300@quicinc.com, stable@vger.kernel.org References: <20250502-qcom-iris-hevc-vp9-v3-0-552158a10a7d@quicinc.com> <20250502-qcom-iris-hevc-vp9-v3-6-552158a10a7d@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250502-qcom-iris-hevc-vp9-v3-6-552158a10a7d@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/05/2025 20:13, Dikshita Agarwal wrote: > HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER is deprecated and no longer > supported on current firmware, remove setting the same to firmware. What about older firmware - what's the effect there ? > At the same time, remove the check for non-zero number of v4l2 controls > as some SOC might not expose any capability which requires v4l2 control. Please break up patches like this one patch removing your legacy functionality - assuming that makes sense another patch amending your non-zero number of v4l2 controls. Generally any commit log or patch title that requires "do this and do that" should be broken up @ the and. --- bod