From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbdHJO10 (ORCPT ); Thu, 10 Aug 2017 10:27:26 -0400 Received: from mout.web.de ([212.227.17.12]:50519 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751439AbdHJO1Y (ORCPT ); Thu, 10 Aug 2017 10:27:24 -0400 To: alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai , Vinod Koul Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ASoC: compress: Delete error messages for a failed memory allocation in snd_soc_new_compress() Message-ID: Date: Thu, 10 Aug 2017 16:26:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:bYRQz9ydepZj2UuJun7zAZMJvwAmUJq2xm4TsjO7PPqyGv29uXR xK+5tj4AEPIaH7t2F795eJziWm83kEmQb1UNPBA+iUrrVEO838QOoERooP5qFdCjyToI1r2 XN/3B35RnFrI/bRwLOxmItRcgEbToXVrlhyzspd0kPiO+HU9vfKGwxYsDc/Bh2Y81+PW8Ef 4LmebSPYnauPm519G03Aw== X-UI-Out-Filterresults: notjunk:1;V01:K0:HCXwBAggfmA=:lMOrNFhoh09V22fv6HjnyU vGkUD7jQuG/qgmreR/Ywje7ZqQQQrA1GGn23fPZ0NOWR9BNXAc9kzlwl363+XqnT8Q85CODYu 5nrh1iMd6xOITmvUGu7adPukBHde4CqpdipJDJCgeSnrC37eLAICcUVmGqHMA12ye9LtQGXJw SpJpLPmbAS3ZqsqdPSHhn4XV21fScaYIxh7ejjCJAdmhDpWU4Garz8cSUuhGo5xGkFB5b3Krz anDLGSXvIEF5jbCm3eIHeObiAu7Ffit7qg9ctWwLhPfCvmpKXVpyKCRdJtHsXggWuAPcHsZGV JJTYI4scdfkME4qk+2moMrc1BQy0a9hU1wFz6nNNUNVpWkZD+GJSyA5RKwvMeDAaVZmjto5Tg lLvGTPVWUDeOtXAv9s0fkk9mwXmqMgDdFPsp9LEtQ08XgphMh+5WFUhb1/ST7Cjnr3eaP4VBL BrxxUThyWGnjAzTGcOrSyTp/LIZo8sq2za95xJTgrv+hTQXCA5kCTjOO+w29R+SNEowu+0Uc/ cwxktOuIgXaus6wbNmPKzC3198zco5RxlGP+W0yOMEI0GDmFoEiEIAEA0AQr88Pt0IzVU1vIE p3q5GmvXzA6nntG674z0XlPDKQrkraQFZluWNCh/AMHlvXd8HzhxVmp4tgawaVHYFqyb0/QYi 8BcgFIqsyN1UuArtVXnjBqLvUAyAqFqhSKC3cj8C6Nyws9//qjJAN0pAMpIyFVujGhEhcucLE jGjNv2HsBjdbtZKIRX5JgvQmw50KPtzzEB3AxPNmF7NNZtKzioxtMIZE2E06qCygPwtu2et4/ yGSJWybB9QmX3+dU3M7Ih/VZjSLJOidlH6NA25VtW9Wp9ASUm0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 10 Aug 2017 16:21:34 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- sound/soc/soc-compress.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index 206f36bf43e8..6c867d50e036 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -764,15 +764,12 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num) direction = SND_COMPRESS_CAPTURE; compr = kzalloc(sizeof(*compr), GFP_KERNEL); - if (compr == NULL) { - snd_printk(KERN_ERR "Cannot allocate compr\n"); + if (!compr) return -ENOMEM; - } compr->ops = devm_kzalloc(rtd->card->dev, sizeof(soc_compr_ops), GFP_KERNEL); - if (compr->ops == NULL) { - dev_err(rtd->card->dev, "Cannot allocate compressed ops\n"); + if (!compr->ops) { ret = -ENOMEM; goto compr_err; } -- 2.14.0