From: Byungchul Park <byungchul.park@lge.com>
To: paulmck@linux.vnet.ibm.com
Cc: jiangshanlai@gmail.com, josh@joshtriplett.org,
rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH] srcu: Fix incorrect condition in srcu_funnel_exp_start()
Date: Mon, 19 Feb 2018 08:36:30 +0900 [thread overview]
Message-ID: <f9abfde2-ad0d-edab-0a2a-a62515ffe870@lge.com> (raw)
In-Reply-To: <20180214214245.GS3617@linux.vnet.ibm.com>
On 2/15/2018 6:42 AM, Paul E. McKenney wrote:
> On Wed, Feb 14, 2018 at 05:59:54PM +0900, Byungchul Park wrote:
>> We should've kept sp->srcu_gp_seq_needed_exp the furthest. But
>> it probably fails because of the incorrect condition. Fix it.
>>
>> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
>
> Good catch, and thank you for reviewing the SRCU code, but Ildar Ismagilov
> beat you to this one. Please see 574428dee1f3 ("rcu: Fix misprint in
> srcu_funnel_exp_start") in -rcu.
Hi Paul,
I'm sorry I'm late. It's been Lunar New Year holiday since last
thursday.
Do you mean:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
Is this rcu's main dev-tree?
Thanks for replying anyway, and happy new year~
>
> Thanx, Paul
>
>> ---
>> kernel/rcu/srcutree.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
>> index d5cea81..44bc0fa 100644
>> --- a/kernel/rcu/srcutree.c
>> +++ b/kernel/rcu/srcutree.c
>> @@ -626,7 +626,7 @@ static void srcu_funnel_exp_start(struct srcu_struct *sp, struct srcu_node *snp,
>> spin_unlock_irqrestore_rcu_node(snp, flags);
>> }
>> spin_lock_irqsave_rcu_node(sp, flags);
>> - if (!ULONG_CMP_LT(sp->srcu_gp_seq_needed_exp, s))
>> + if (ULONG_CMP_LT(sp->srcu_gp_seq_needed_exp, s))
>> sp->srcu_gp_seq_needed_exp = s;
>> spin_unlock_irqrestore_rcu_node(sp, flags);
>> }
>> --
>> 1.9.1
>>
>
>
--
Thanks,
Byungchul
next prev parent reply other threads:[~2018-02-18 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 8:59 Byungchul Park
2018-02-14 21:42 ` Paul E. McKenney
2018-02-18 23:36 ` Byungchul Park [this message]
2018-02-19 1:04 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9abfde2-ad0d-edab-0a2a-a62515ffe870@lge.com \
--to=byungchul.park@lge.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®