From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752658AbcHKKDW (ORCPT ); Thu, 11 Aug 2016 06:03:22 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:60959 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbcHKKDT (ORCPT ); Thu, 11 Aug 2016 06:03:19 -0400 Subject: Re: [PATCH] drm/omap: remove unneeded conversions to bool To: "Andrew F. Davis" References: <20160701142721.17096-1-afd@ti.com> CC: David Airlie , , From: Tomi Valkeinen Message-ID: Date: Thu, 11 Aug 2016 13:03:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160701142721.17096-1-afd@ti.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h8UE8bWiukTN1doHUevJc0VqLcla70DOS" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --h8UE8bWiukTN1doHUevJc0VqLcla70DOS Content-Type: multipart/mixed; boundary="cMeaDNNVjlxRpdFmhigfo4KQaRfU6XGUL" From: Tomi Valkeinen To: "Andrew F. Davis" Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] drm/omap: remove unneeded conversions to bool References: <20160701142721.17096-1-afd@ti.com> In-Reply-To: <20160701142721.17096-1-afd@ti.com> --cMeaDNNVjlxRpdFmhigfo4KQaRfU6XGUL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/07/16 17:27, Andrew F. Davis wrote: > Found with scripts/coccinelle/misc/boolconv.cocci. >=20 > Signed-off-by: Andrew F. Davis > --- > drivers/gpu/drm/omapdrm/dss/dispc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omap= drm/dss/dispc.c > index f83608b..495094b 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dispc.c > +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c > @@ -1655,7 +1655,7 @@ static void dispc_ovl_set_scaling_uv(enum omap_pl= ane plane, > { > int scale_x =3D out_width !=3D orig_width; > int scale_y =3D out_height !=3D orig_height; > - bool chroma_upscale =3D plane !=3D OMAP_DSS_WB ? true : false; > + bool chroma_upscale =3D plane !=3D OMAP_DSS_WB; > =20 > if (!dss_has_feature(FEAT_HANDLE_UV_SEPARATE)) > return; > @@ -3086,9 +3086,9 @@ static bool _dispc_mgr_pclk_ok(enum omap_channel = channel, > unsigned long pclk) > { > if (dss_mgr_is_lcd(channel)) > - return pclk <=3D dispc.feat->max_lcd_pclk ? true : false; > + return pclk <=3D dispc.feat->max_lcd_pclk; > else > - return pclk <=3D dispc.feat->max_tv_pclk ? true : false; > + return pclk <=3D dispc.feat->max_tv_pclk; > } > =20 > bool dispc_mgr_timings_ok(enum omap_channel channel, >=20 Thanks, queued for v4.9. Tomi --cMeaDNNVjlxRpdFmhigfo4KQaRfU6XGUL-- --h8UE8bWiukTN1doHUevJc0VqLcla70DOS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXrE1iAAoJEPo9qoy8lh71szMP/iiHRr5FoPva5lk++xivnShO kBh2ixXFXgoxYmgY19JbgKcqjUqAlxMQpFYvDcP9zmhCBRCkPPnxUkRj0PqCbz1t 87ooUKrgOQh40ne7cxTJx5GPnajKonS4d8MCHJd2+OlparB2puCyARftjnEs+DSe KNTjnqPPgPWy83+vCXrN+7Skm6T2oYM0M5e0JPvd7Q5sWSvOZ9oDxNBsBo3XhRhu hf0K68RWZhUbXRifjdE72w/ZFAdN8VcoysbG4hUMsUsOIi2OPsUYe4a1wl3RAOdQ UH8RTR6BNA/zxd+SJgSuI1AvzDW5YI9/1bk8H+C+a+aRi+Xrt8ngctMTmMqtHNjK 4P/opbM/X/7wvjq1/ovWp/vea0nxDN6Hb7tqbe/TgyP+L9oMpQlkf3D2DNwVkN9s YOrS+BsZWrTA80A+ONEKxq+5Li87cgx0YrZh2xqcl3U37n7f+ZpmpaRfOjdE7ZBi 5Tr04YqdNTVLHgxQGlAfvxDAvxTHmaAaxgWGK6VutsYt86sndo3agedNL1h7yPPZ Z0vSMVACbfwfRkDZ0dtHWw7CmjJ50A03WIR+gcCmowF0Ai0xIPZ6XOUuF5R3O90l tGnSuk7OEFcQ/6zTsPxHDh9w1Ecpf4Dhz8Oc/BiN7dWXN8KjRqFKzH+iC98JZ89s aC85c9tOcmM2A2dHnKqO =HJ3x -----END PGP SIGNATURE----- --h8UE8bWiukTN1doHUevJc0VqLcla70DOS--