mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Nam Cao <namcao@linutronix.de>
Cc: Ryan England <rcengland@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: rtl8712: fix open parentheses alignment
Date: Wed, 3 Jan 2024 16:19:45 +0300	[thread overview]
Message-ID: <f9b34a72-42e1-43f6-b03c-5a3d05773862@moroto.mountain> (raw)
In-Reply-To: <20231222094735.5554b67a@namcao>

On Fri, Dec 22, 2023 at 09:47:35AM +0100, Nam Cao wrote:
> On Thu, 21 Dec 2023 20:22:48 +0000 Ryan England <rcengland@gmail.com> wrote:
> 
> > Adhere to Linux kernel coding style.
> > 
> > Reported by checkpatch:
> > 
> > CHECK: Alignment should match open parenthesis
> > 
> > Signed-off-by: Ryan England <rcengland@gmail.com>
> > ---
> > Made corrections give the 100 line limit. Resending v2 as no change was
> > made other than including this comment below ---. Thank you for the
> > correction. Here's to learning with every submission.
> > 
> >  drivers/staging/rtl8712/os_intfs.c            |   3 +-
> >  drivers/staging/rtl8712/rtl8712_efuse.c       |   9 +-
> >  drivers/staging/rtl8712/rtl8712_recv.c        |   3 +-
> >  drivers/staging/rtl8712/rtl8712_xmit.c        |  60 +++---
> >  drivers/staging/rtl8712/rtl871x_cmd.c         | 159 +++++---------
> >  drivers/staging/rtl8712/rtl871x_cmd.h         |  37 ++--
> >  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 203 +++++++-----------
> >  7 files changed, 173 insertions(+), 301 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> > index b18e6d9c832b..7554613fe7e1 100644
> > --- a/drivers/staging/rtl8712/os_intfs.c
> > +++ b/drivers/staging/rtl8712/os_intfs.c
> > @@ -221,8 +221,7 @@ struct net_device *r8712_init_netdev(void)
> >  
> >  static u32 start_drv_threads(struct _adapter *padapter)
> >  {
> > -	padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s",
> > -					  padapter->pnetdev->name);
> > +	padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s", padapter->pnetdev->name);
> 
> Your description claims to fix "CHECK: Alignment should match open
> parenthesis", but this one is already aligned, isn't it?

No.  It was not aligned.  There was a space character missing.

regards,
dan carpenter


  reply	other threads:[~2024-01-03 13:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21 20:22 Ryan England
2023-12-22  8:40 ` Nam Cao
2023-12-22  8:47 ` Nam Cao
2024-01-03 13:19   ` Dan Carpenter [this message]
2024-01-03 13:32     ` Nam Cao
2023-12-22  8:52 ` Nam Cao
2023-12-22  8:56   ` Nam Cao
  -- strict thread matches above, loose matches on Subject: below --
2023-12-20 18:48 Ryan England
2023-12-21  7:50 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9b34a72-42e1-43f6-b03c-5a3d05773862@moroto.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=namcao@linutronix.de \
    --cc=outreachy@lists.linux.dev \
    --cc=rcengland@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®