From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754285AbdFNGOG (ORCPT ); Wed, 14 Jun 2017 02:14:06 -0400 Received: from mga11.intel.com ([192.55.52.93]:7729 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbdFNGOF (ORCPT ); Wed, 14 Jun 2017 02:14:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,340,1493708400"; d="scan'208";a="1160263966" Subject: Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static To: Colin King , Ulf Hansson , linux-mmc@vger.kernel.org, Christoph Hellwig Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170613131426.8132-1-colin.king@canonical.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Wed, 14 Jun 2017 09:08:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170613131426.8132-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/17 16:14, Colin King wrote: > From: Colin Ian King > > The guid intel_dsm_guid does not need to be in global scope, so make > it static. > > Cleans up sparse warning: > "symbol 'intel_dsm_guid' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King Acked-by: Adrian Hunter But this patch is dependent on the guid changes which are not in the mmc tree. It's in a tree of Christoph's I think. > --- > drivers/mmc/host/sdhci-pci-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c > index 3c02c5b394d6..f1d8385d91f0 100644 > --- a/drivers/mmc/host/sdhci-pci-core.c > +++ b/drivers/mmc/host/sdhci-pci-core.c > @@ -404,7 +404,7 @@ struct intel_host { > bool d3_retune; > }; > > -const guid_t intel_dsm_guid = > +static const guid_t intel_dsm_guid = > GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F, > 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61); > >