From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1825BC3DA79 for ; Thu, 29 Dec 2022 10:25:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233394AbiL2KZJ (ORCPT ); Thu, 29 Dec 2022 05:25:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233201AbiL2KYi (ORCPT ); Thu, 29 Dec 2022 05:24:38 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 685A713DEC for ; Thu, 29 Dec 2022 02:23:05 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id j17so17438483lfr.3 for ; Thu, 29 Dec 2022 02:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xT1pcIHoVC+1Kb3uKk2wZih8Ww6QX+aLdKaotJW20mU=; b=NxVs//1rsJfC8Xq6Fxx8I/9s10fHxROXpoiHgzhOwM/wFk2aGYViA9Bd8tVJ1z9wXF rUljgrbdKizmoFK4g105uBaUZKD9tDjMeSLM6/jKe3ZNUi1aPLmyU+/F7gZF5xbedLny R8oKCUwJ3qA2GQMEGU5wbsBte813yqJs6TSdHqoms0VJmgIS8oqdCuH73svzQxrD/et2 anJFvY02Pt8ZQ9NKYGXkSysMzxdWyH99OAmqOroNRKsm1zKv1/0O2IqL/lJOqzujtM+u O9baICV29kw4+NcAPMXjJ+ybVRv1dKNnBe4+PDcNyUxcVeb3y+F86uBSVx32iEWW5cuc PCZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xT1pcIHoVC+1Kb3uKk2wZih8Ww6QX+aLdKaotJW20mU=; b=CgJt1PzKwLr9rtSywUbxzDKIeIrQPBBbP05I0kHi8ZL26amtdbo0gqh1ziCOUrnYFy pE+p/H33RAiYFDCPX9XWOMtjJT9LmzZCo1kc652e4bxFAOcIm704a5koc/lRe/mcVhSU h8bYje4WVMr3wNFeLkpCXFN2yJs+JamLDfusOh3Bi3pGfEyLMkDimr6mb18Kse8RrCAX 3GsQc7YVJXr3dcYrnW4VwFkX2fj1daSbaNNvCJ2L68mFmDwXI55snnl9u9LSmX1yN5r/ Rtl2iU3a6AvydniIr5Xe66XRNFDe+s2fA5x7BGIEEbqe5HNWi4TyiI7E2cOhSCw0112M bdJQ== X-Gm-Message-State: AFqh2krbRNF4J1M5SPUOgXhJ2/7ycrO0K+Fi4BusBi97tJUosI/GrBwm YfAm/hZz076UBAtYMryM939viJkOCqcPvcKD X-Google-Smtp-Source: AMrXdXuejIrgLC617Mnl3g4WkCNbIZz1YM58zJh2SFp42JdgDiuwOxHKRRlnkX9vo6cIau7UJ5fAuQ== X-Received: by 2002:a05:6512:4005:b0:4b5:9183:5ad0 with SMTP id br5-20020a056512400500b004b591835ad0mr10354256lfb.63.1672309383759; Thu, 29 Dec 2022 02:23:03 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id s16-20020a056512203000b004b4a0482a53sm2986603lfs.231.2022.12.29.02.23.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Dec 2022 02:23:03 -0800 (PST) Message-ID: Date: Thu, 29 Dec 2022 11:23:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v2 3/3] dt-bindings: usb: snps,dwc3: add generic-xhci as child Content-Language: en-US To: Daehwan Jung , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Thinh Nguyen , Mathias Nyman , Felipe Balbi Cc: "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , sc.suh@samsung.com, taehyun.cho@samsung.com, jh0801.jung@samsung.com, eomji.oh@samsung.com References: <1672307866-25839-1-git-send-email-dh10.jung@samsung.com> <1672307866-25839-4-git-send-email-dh10.jung@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <1672307866-25839-4-git-send-email-dh10.jung@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/12/2022 10:57, Daehwan Jung wrote: > Currently, dwc3 invokes just xhci platform driver(generic-xhci) without > DT schema even though xhci works as child of dwc3. It makes sense to add > xhci as child of dwc3 with DT schema. It also supports to use another > compatible in xhci platform driver. You use some driver as an argument for hardware description, which is not what we need. Describe the hardware. > > Signed-off-by: Daehwan Jung > --- > .../devicetree/bindings/usb/snps,dwc3.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index 6d78048c4613..83ed7c526dba 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -360,8 +360,22 @@ properties: > description: > Enable USB remote wakeup. > > + "#address-cells": > + enum: [ 1, 2 ] > + > + "#size-cells": > + enum: [ 1, 2 ] > + > + ranges: true > + > unevaluatedProperties: false > > +# Required child node: > +patternProperties: > + "^usb@[0-9a-f]+$": > + $ref: generic-xhci.yaml# > + description: Required child node DWC does not have another piece of controller as child... DWC is the controller. Not mentioning that you now affect several other devices without describing the total hardware picture (just some drivers which is not that relevant). > + > required: > - compatible > - reg > @@ -388,4 +402,19 @@ examples: > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > }; > + - | > + usb@4a200000 { > + compatible = "snps,dwc3"; > + reg = <0x4a200000 0xcfff>; > + interrupts = <0 92 4>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + xhci: usb@4a200000 { > + compatible = "generic-xhci"; There are no such device... > + reg = <0x4a200000 0x7fff>; > + interrupts = <0 92 4>; > + }; > + }; > ... Best regards, Krzysztof