From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415E0C4332F for ; Fri, 11 Feb 2022 17:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349563AbiBKREZ (ORCPT ); Fri, 11 Feb 2022 12:04:25 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:58898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241724AbiBKREX (ORCPT ); Fri, 11 Feb 2022 12:04:23 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 95E363B3 for ; Fri, 11 Feb 2022 09:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644599060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KYptzzuR1nRVaqjLXcd0YpNLgMFhMfqS6KLF2X09zmk=; b=RbJU5WGTf4HqTpcR3/CQX1HI6QQPu/qPPS0S93Ga2J8z+hN/G1OeqV0OGjAp/0zVc7Shlr XASqxGR0uEWoh70YHcgdfVHLDugwwy+TJRyTWUh5TpGe/eVKJzsNUXFuVsXKRv951btOTX mFFwvbTKMqxUd3UTxyxQBIW0T4znSSc= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-657-qYd2ZyZZOFe1wHLbFyXSkQ-1; Fri, 11 Feb 2022 12:04:19 -0500 X-MC-Unique: qYd2ZyZZOFe1wHLbFyXSkQ-1 Received: by mail-ed1-f69.google.com with SMTP id 30-20020a508e5e000000b0040f6642e814so5619497edx.19 for ; Fri, 11 Feb 2022 09:04:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KYptzzuR1nRVaqjLXcd0YpNLgMFhMfqS6KLF2X09zmk=; b=v62km1RR/XuwiYgf/D+3HlXBtyBjwxtbwwIBmSVv9bdInDMGl5I4XF5DBSrL8XtpkG +3Y+FJXql0x040yohq+zPgppuJW066RDJOhAG4A+55xZ40dTC1JnuaInIlur9tAiQrlV 1qsw+L4vE8nNZv1fZBn0mX+xZ8+Eeo3SIUtjRYvL0sYPPq862GzInRayKAoCxkGeOyo3 loL5RNaDgoXtiGrApSSKjFMXAoFsAVne5CzMvcD8l4AVmbe1815MrVFP+qF4bT4bFAeq wZlidf1vnSn6zRJfdRhkYifNf86X2WlRzkeIK+qgqXryGddU38fVwtCQaNSCtpOCMw1B 7fGA== X-Gm-Message-State: AOAM5328kgOhMsxiWaVQggDcsYnQQsjTTNF/a3hwAkOZRVCW1H8BMEwx wLWB9MxC6HzHBjkckWlA81qIinEdgm/gAkY2TGMjhZgLAK+rlXnUCzspUmcqdCugvIvQEfGgSTs oVZSaA0rVGa8FBmK/NRcgKwaL X-Received: by 2002:a17:907:3ea8:: with SMTP id hs40mr2128563ejc.735.1644599058184; Fri, 11 Feb 2022 09:04:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxv3OGJ97g/9VhVJFwY2nWNdHnB645TanqX4RlrDEEAqgX3mlcjN7rfDf5geKP/v54xNTXTbg== X-Received: by 2002:a17:907:3ea8:: with SMTP id hs40mr2128545ejc.735.1644599057972; Fri, 11 Feb 2022 09:04:17 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id o4sm6036116edq.45.2022.02.11.09.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 09:04:17 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 18:04:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 0/3] KVM: x86: Fixes for kvm/queue Content-Language: en-US To: Sean Christopherson , Wanpeng Li Cc: Lai Jiangshan , LKML , kvm , Maxim Levitsky , Lai Jiangshan References: <20211216021938.11752-1-jiangshanlai@gmail.com> <7fc9348d-5bee-b5b6-4457-6bde1e749422@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/22 17:31, Sean Christopherson wrote: >> Maybe the patch "Revert "KVM: VMX: Save HOST_CR3 in >> vmx_prepare_switch_to_guest()"" is still missing in the latest >> kvm/queue, I saw the same warning. > > It hasn't made it way to Linus either. This was supposed to fix the buggy patch, too: commit a9f2705ec84449e3b8d70c804766f8e97e23080d Author: Lai Jiangshan Date: Thu Dec 16 10:19:36 2021 +0800 KVM: VMX: Save HOST_CR3 in vmx_set_host_fs_gs() The host CR3 in the vcpu thread can only be changed when scheduling, so commit 15ad9762d69f ("KVM: VMX: Save HOST_CR3 in vmx_prepare_switch_to_guest()") changed vmx.c to only save it in vmx_prepare_switch_to_guest(). However, it also has to be synced in vmx_sync_vmcs_host_state() when switching VMCS. vmx_set_host_fs_gs() is called in both places, so rename it to vmx_set_vmcs_host_state() and make it update HOST_CR3. Fixes: 15ad9762d69f ("KVM: VMX: Save HOST_CR3 in vmx_prepare_switch_to_guest()") Signed-off-by: Lai Jiangshan Message-Id: <20211216021938.11752-2-jiangshanlai@gmail.com> Signed-off-by: Paolo Bonzini Paolo