From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 186A3471417 for ; Tue, 21 Jul 2026 20:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664682; cv=none; b=I87kLa6iBl/VXQ/VhrLWOkWIpWaKphvD7Ap4/hstr/L/GT46BYLBxjVAURaI2gJwjQ6viC5em796mMu9rgtNJWpmvhO1izQGgBl/GPerAfFCrIMZQpknW5lLLtbbSbZMp/QjDrBJduKcY68f41+Xl4O0TzRW9jmFWEpcWRUsQpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664682; c=relaxed/simple; bh=8STlPBMjUmN2TUHF6C93L4PXle+urAG6HatJTuHYE6s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WJKtBM/sJtwwq2JfikDe73z0vEpmSlpbTx0DLOg9La72GId6yHuImnYzSXECSyzTLH4BGSYHoIiRBDsnQWc0b5mqRdoH3EimGdJTvfvNXhfvQx6tlvBQhjlWf3/tN4e90TMtwVWnkWC39xjmrKYhlSruxBnMmokYI1mfpVb79T8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c2tI1/uT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FRqb4cbB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c2tI1/uT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FRqb4cbB" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LH2dFY2160329 for ; Tue, 21 Jul 2026 20:11:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8STlPBMjUmN2TUHF6C93L4PXle+urAG6HatJTuHYE6s=; b=c2tI1/uTLTbI3qrI YHVsWWP3KOvbPVdx9oWG/BhbtOT9oCiMzH43R/TRHEA6wM8mW1VSOAwL5T85ikMt cDFrb8NAef6cCGIBMiow/xUvvlLZ4T6nqkAQwzEI90fUxyHbW50gG/j5uysdaaR1 z7WU0CwloAijHHSznHwAE+NQF6V4RK8tXmPAEZd7MCHKwQyzsD9HdlgfGUuX9Bjd lExltLuIcl5tIHuecN3bmzssjeeVfaO2BZcotCgiw2azvCEO26DZTT26Hxx877HC Jerz3gMnqYpIZVWEo8IP+CnFSkxNsKif+0nCnzVu1cppGliGf1cx5wbNroAGs1Gt UflqVA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj9c41ygq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 20:11:20 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84e09f9b07cso244444b3a.1 for ; Tue, 21 Jul 2026 13:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784664679; x=1785269479; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8STlPBMjUmN2TUHF6C93L4PXle+urAG6HatJTuHYE6s=; b=FRqb4cbBtfODvPbC8qGqwTzBUeeR+MsrlNpxTm/43gvwu1Css1aFdqkiPkh1P7RTuW djU/zDkDTGCmzxW5LAUD3cZzmKdlBaPi5XN6aZC9ECY5PICbhNzk+8EMklHP9kRjOh/q d9MY9jJMVtd9ElCzZ0zon8wdnIK1u5HjQZ9xlX2RWvLc8nb3ttUrvEPUvavM7UNcnu/g yF0DrYNL1uqcTRDNDwgaIm5zN1OXx0mTgnxIiZVkxcn/w+xIq85jp3EBEEBy6mw9bF5C V1pIcq9mY1xXZnS6SlqfVHhGxnQ8CIgWI0lWfQ/U8L+Khct9yMr1uSidu4j97x3zEcr7 HZDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784664679; x=1785269479; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8STlPBMjUmN2TUHF6C93L4PXle+urAG6HatJTuHYE6s=; b=S0XQRYf7b1dTuhBFC1w8VOE5grlZXczlOGzMTgz0fnm9HXwbMvzMHUazjIDZm7w1jg H5OXU0uvLdug33vwvXEVflwi2dOj/wO9Eww+oUiYn1uF3yg26BzFDRvuDzIlLSVtS5AY DH17WMFk9oBBiO9YRzMKe+ItR6GgOI8DFtKZKhbkFrNkocptPK4DksEngWWu51fR/pB4 BCGHdltCpcsVDDd7J8YGDHHYsrQyo3au2E1c9y7axtU7yT9qa4Qy9Xx6pFAkZU4+F+jb YpdUuq3eXkUII3MNILNrTu88k4OMjYJuQW2+uKXejK/hFebqdakXo7fvvc/OsO7glpct gzVw== X-Forwarded-Encrypted: i=1; AHgh+Rp9cfL9iBJjjIGt/5CnWkaiitv6+KabMmZig0t8aWwaP7Yig2lei18pr1sYnc/rkY6aKnKjTAO4PL3xJpE=@vger.kernel.org X-Gm-Message-State: AOJu0YzLIk0SMwlTsrSP8hAOHHJq9dlE1ipEgByz6FI3V9jXdSH0txgP R91UvRuOmwYjMRK10ZjcvVdV8PbpeYYeqOcC42NLUVqIDRC9E1b75Q3UApHRN7BWTieRQslsnmz ES8N2KB7orSw1Rb/ORDTUqlfD6HiBU51Ji4RHV3SLCJkAJ3Z8/xNPxnYozrTAs8frwX8= X-Gm-Gg: AR+sD12lAxgX1Emwkv9rzsnjAe2YUhUrB2KQ1EaXp8oNUb2BJob2ojtCPijZ3PFtDUI +gnfB4qhH72tZHBw3AscI5CTyIvdlttkoaU14U+P5ORnGzoOlcxCHRpi/19lmYiA76FYv0hgQ/V OZQN25v/98oCXX8km0bN2kEGzYifAvbYKdNqCS0T10S/VWhcBvcPPq3BEQeQbxoGTQWGw7Jofw9 rcxuu5VjVzAyqt/ky3DRNaxmnTDdcgcspFm3H+8TKvHmw8IkEuZLrQx3u6rUphK6+3kq/IshkFu wgQ1T3WO7R11htAM+U5BP79mD9298235uFCXtqO5qrNK2eUNPrr3My5gLjEGyRjHWVhtpuKqyZ6 BZ/4FnLn63vAQfnlm1ZLRVb80wIUor2OGwX7Gk/oA84CPycqNV1N4UN4OajZZ8tK0WH0= X-Received: by 2002:a05:6a00:3c95:b0:847:88aa:4f4f with SMTP id d2e1a72fcca58-84e180acff3mr294749b3a.7.1784664679321; Tue, 21 Jul 2026 13:11:19 -0700 (PDT) X-Received: by 2002:a05:6a00:3c95:b0:847:88aa:4f4f with SMTP id d2e1a72fcca58-84e180acff3mr294727b3a.7.1784664678877; Tue, 21 Jul 2026 13:11:18 -0700 (PDT) Received: from [10.133.33.193] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e1723a089sm235566b3a.8.2026.07.21.13.11.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 13:11:18 -0700 (PDT) Message-ID: Date: Wed, 22 Jul 2026 04:11:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] Bluetooth: Add generic support for vendor HCI frames To: Luiz Augusto von Dentz Cc: Marcel Holtmann , Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260719-support_vendor_hci-v1-1-764523a4ca3d@oss.qualcomm.com> <0c5a924f-7382-407b-a0f4-dfd7dfe0d5e6@oss.qualcomm.com> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I4JVgtgg c=1 sm=1 tr=0 ts=6a5fd268 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=TtAbrmqVTDRL7XDSG4AA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: BCbwb7xb_O56d-qEiXuCmnpz6HFA6OXi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDIxMCBTYWx0ZWRfX9GaKGjhAiBvP i2EC1V86WDhoHpEuktRd0B0jZ/h8T6P9o1wdrtmUYjbUUKIh7AB8abJ1S2uy55IoYudKEcogcTt S9w2413i7615sefuy7Ql1wXk5oiLtN1Dkjhe/K3NSTXWU9vsnm6aNijsLTEncryuyz1JOO+azrn POnZ56yQxhwQO+zhETg4I3j5cOCtJWcQ60eZYj6DehssUHPnKv3eGEVO1PBW+wngmmlkDWz1DIb ZBxKzL15GwpnVTr6xVuHY3jV2o21EoOMQ5vvOgFVNeKOWrgvzFH5ZmRm3m/h26VM1bxkbqUC5ad 8mEv/Y9mPKZ+OPih6ae01JFkaY5YKKlsD+7dJdj7lcpaU+yC+Ra3mtaOA21uGutXQRZ1Jly56b1 79blEm1Nu7gOX+QN6EbYaJJtgCCv5Pbo+nhi3eNVXawNiuNc8uX/0Cias2kZTGv9TUeCRMymAM3 tz4CoyfXRjvSOKP1ydg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDIxMCBTYWx0ZWRfXzbkbgnETCfN9 OvaAWsQvyfssv33+9WbGbRiGjNaYzk8VwYFYdfG8ypR7vQN4LTTRvox0sBV4BQw5u56G3kQ3YyG XfR1XQqJsaiEHg24+WuPezvIqDg3AsU= X-Proofpoint-GUID: BCbwb7xb_O56d-qEiXuCmnpz6HFA6OXi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210210 On 7/22/2026 3:49 AM, Luiz Augusto von Dentz wrote: > For the user channel I would say it would be better to always include > 0xff. That way, it remains agnostic and it won't suddenly match a > different packet type if you change the vendor or something like that. so, perhaps, you original proposal(Option A) is better and easier to implement than this simpler one since it uses consistent way to decide vendor HCI frame. 1) userspace <-> kernel : 0xff + vendor hci indicator. 2) for RX, transport driver stamp with HCI_VENDOR_PKT before hci_recv_frame() For TX, transport driver pull one more byte(indicator) for HCI_VENDOR_PKT frame tell type of vendor hci frames. let me also give a implementation for this 'Option A' as well.